Re: [PATCH] drm/i915: Annotate dma_fence waits

From: kbuild test robot <lkp@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	kbuild-all@01.org
Subject: Re: [PATCH] drm/i915: Annotate dma_fence waits
Date: Wed, 7 Nov 2018 00:48:56 +0800	[thread overview]
Message-ID: <201811070004.u5Yh3ltp%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181106135527.28354-1-daniel.vetter@ffwll.ch>

[-- Attachment #1: Type: text/plain, Size: 2959 bytes --]

Hi Daniel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.20-rc1 next-20181106]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Annotate-dma_fence-waits/20181106-232827
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x000-201844 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/i915/i915_request.c: In function 'i915_request_wait':
>> drivers/gpu//drm/i915/i915_request.c:1292:3: error: implicit declaration of function 'dma_fence_wait_acquire'; did you mean 'dma_fence_wait_timeout'? [-Werror=implicit-function-declaration]
      dma_fence_wait_acquire();
      ^~~~~~~~~~~~~~~~~~~~~~
      dma_fence_wait_timeout
>> drivers/gpu//drm/i915/i915_request.c:1295:3: error: implicit declaration of function 'dma_fence_wait_release'; did you mean 'dma_fence_release'? [-Werror=implicit-function-declaration]
      dma_fence_wait_release();
      ^~~~~~~~~~~~~~~~~~~~~~
      dma_fence_release
   cc1: some warnings being treated as errors

vim +1292 drivers/gpu//drm/i915/i915_request.c

  1265	
  1266	/**
  1267	 * i915_request_wait - wait until execution of request has finished
  1268	 * @rq: the request to wait upon
  1269	 * @flags: how to wait
  1270	 * @timeout: how long to wait in jiffies
  1271	 *
  1272	 * i915_request_wait() waits for the request to be completed, for a
  1273	 * maximum of @timeout jiffies (with MAX_SCHEDULE_TIMEOUT implying an
  1274	 * unbounded wait).
  1275	 *
  1276	 * If the caller holds the struct_mutex, the caller must pass I915_WAIT_LOCKED
  1277	 * in via the flags, and vice versa if the struct_mutex is not held, the caller
  1278	 * must not specify that the wait is locked.
  1279	 *
  1280	 * Returns the remaining time (in jiffies) if the request completed, which may
  1281	 * be zero or -ETIME if the request is unfinished after the timeout expires.
  1282	 * May return -EINTR is called with I915_WAIT_INTERRUPTIBLE and a signal is
  1283	 * pending before the request completes.
  1284	 */
  1285	long i915_request_wait(struct i915_request *rq,
  1286			       unsigned int flags,
  1287			       long timeout)
  1288	{
  1289		long ret;
  1290	
  1291		if (!lockdep_is_held(&rq->i915->drm.struct_mutex))
> 1292			dma_fence_wait_acquire();
  1293		ret = __i915_request_wait(rq, flags, timeout);
  1294		if (!lockdep_is_held(&rq->i915->drm.struct_mutex))
> 1295			dma_fence_wait_release();
  1296	
  1297		return ret;
  1298	}
  1299	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33001 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx