All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH 0/4] Fix common issue in MAX* extcon drivers
Date: Thu, 08 Nov 2018 14:45:44 +0100	[thread overview]
Message-ID: <20181108134548.31140-1-m.szyprowski@samsung.com> (raw)
In-Reply-To: CGME20181108134553eucas1p1a513f538b74fab263c3f143914d30720@eucas1p1.samsung.com

Hi All

Most MAX* MUIC drivers unconditionally force UART path during probe.
This approach causes some issues, especially when board is booted with
non-UART cable connected to micro-USB port. For example, when USB cable is
connected, UART TX/RX lines are unconditionally short-circuited to USB
D+/D- lines. This is in turn recognized by a series of serial BREAK
signals and some random characters when USB host tries to perform
enumeration procedure.

To solve the above issue and keep UART console operational as early as
possible, set UART path only when USB ID reports UART capable cable.

This patchset fixes following MAX* extcon drivers: 8997, 14577, 77693
and 77843.

Tested on following Samsung boards: Trats (8997), Rinato (14577), Trats2
(77693) and TM2/TM2e (77843).

Best regards
Marek Szyprowski
Samsung R&D Institute Poland


Patch summary:

Marek Szyprowski (4):
  extcon: max77843: Avoid forcing UART path on drive probe
  extcon: max77693: Avoid forcing UART path on drive probe
  extcon: max14577: Avoid forcing UART path on drive probe
  extcon: max8997: Avoid forcing UART path on drive probe

 drivers/extcon/extcon-max14577.c | 15 +++++++++++++--
 drivers/extcon/extcon-max77693.c | 16 ++++++++++++++--
 drivers/extcon/extcon-max77843.c | 18 +++++++++++++++---
 drivers/extcon/extcon-max8997.c  | 15 +++++++++++++--
 4 files changed, 55 insertions(+), 9 deletions(-)

-- 
2.17.1


       reply	other threads:[~2018-11-08 13:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181108134553eucas1p1a513f538b74fab263c3f143914d30720@eucas1p1.samsung.com>
2018-11-08 13:45 ` Marek Szyprowski [this message]
     [not found]   ` <CGME20181108134554eucas1p20df6cef615670df482e1f6c8ac4b86de@eucas1p2.samsung.com>
2018-11-08 13:45     ` [PATCH 1/4] extcon: max77843: Avoid forcing UART path on drive probe Marek Szyprowski
     [not found]   ` <CGME20181108134554eucas1p12694abede1bf0ce633d4890e2297b685@eucas1p1.samsung.com>
2018-11-08 13:45     ` [PATCH 2/4] extcon: max77693: " Marek Szyprowski
     [not found]   ` <CGME20181108134554eucas1p26363910951ef941a3b80f47a1c0006c2@eucas1p2.samsung.com>
2018-11-08 13:45     ` [PATCH 3/4] extcon: max14577: " Marek Szyprowski
     [not found]   ` <CGME20181108134555eucas1p10f126bdad7538c224d97be4f7e31e4bb@eucas1p1.samsung.com>
2018-11-08 13:45     ` [PATCH 4/4] extcon: max8997: " Marek Szyprowski
2018-11-12  0:18   ` [PATCH 0/4] Fix common issue in MAX* extcon drivers Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108134548.31140-1-m.szyprowski@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.