From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fpga@vger.kernel.org
Subject: Re: [PATCH 5/5] fpga: dfl-fme-region: Use platform_get_drvdata()
Date: Mon, 12 Nov 2018 10:02:06 -0800 [thread overview]
Message-ID: <20181112180206.GA28739@kroah.com> (raw)
In-Reply-To: <CANk1AXR=psRx319i_2S3fqM+4WsK6YgwJMPn=2o3zw5AQ3mr6w@mail.gmail.com>
On Mon, Nov 12, 2018 at 09:46:53AM -0600, Alan Tull wrote:
> On Sun, Sep 30, 2018 at 10:48 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>
> Hi Greg,
>
> >
> > On Wed, Sep 12, 2018 at 09:43:27AM -0500, Alan Tull wrote:
> > > From: Moritz Fischer <mdf@kernel.org>
> > >
> > > Use platform_get_drvdata() in remove() function of
> > > the platform driver rather than dev_get_drvdata()
> > > to match the platform_set_drvdata in the probe().
> > >
> > > Signed-off-by: Moritz Fischer <mdf@kernel.org>
> > > Acked-by: Alan Tull <atull@kernel.org>
> > > ---
> > > drivers/fpga/dfl-fme-region.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
> > > index 51a5ac2..3fa0de2 100644
> > > --- a/drivers/fpga/dfl-fme-region.c
> > > +++ b/drivers/fpga/dfl-fme-region.c
> > > @@ -66,7 +66,7 @@ static int fme_region_probe(struct platform_device *pdev)
> > >
> > > static int fme_region_remove(struct platform_device *pdev)
> > > {
> > > - struct fpga_region *region = dev_get_drvdata(&pdev->dev);
> > > + struct fpga_region *region = platform_get_drvdata(pdev);
> >
> > This is nice, but not a bugfix. I'll wait for 4.20-rc1 for this patch.
>
> Could you take patch 4/5 and 5/5? They didn't make it into a 4.20 rc yet.
Can you resend them please? I don't see either of these in my queue
anywhere.
thanks,
greg k-h
next prev parent reply other threads:[~2018-11-12 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 14:43 [PATCH 0/5] fpga: patches for v4.19 Alan Tull
2018-09-12 14:43 ` [PATCH 1/5] fpga: do not access region struct after fpga_region_unregister Alan Tull
2018-09-12 14:43 ` [PATCH 2/5] fpga: bridge: fix obvious function documentation error Alan Tull
2018-09-12 14:43 ` [PATCH 3/5] docs: fpga: document fpga manager flags Alan Tull
2018-09-12 14:43 ` [PATCH 4/5] fpga: of-fpga-region: Use platform_set_drvdata Alan Tull
2018-09-30 15:49 ` Greg Kroah-Hartman
2018-11-12 15:48 ` Alan Tull
2018-09-12 14:43 ` [PATCH 5/5] fpga: dfl-fme-region: Use platform_get_drvdata() Alan Tull
2018-09-30 15:48 ` Greg Kroah-Hartman
2018-11-12 15:46 ` Alan Tull
2018-11-12 18:02 ` Greg Kroah-Hartman [this message]
2018-11-12 19:39 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112180206.GA28739@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=atull@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.