From: Jeff King <peff@peff.net>
To: Max Kirillov <max@max630.net>
Cc: git@vger.kernel.org, Carlo Arenas <carenas@gmail.com>
Subject: Re: [PATCH] t5562: fix perl path
Date: Sat, 24 Nov 2018 07:10:37 -0500 [thread overview]
Message-ID: <20181124121036.GC19257@sigill.intra.peff.net> (raw)
In-Reply-To: <20181122233821.17871-1-max@max630.net>
On Fri, Nov 23, 2018 at 01:38:21AM +0200, Max Kirillov wrote:
> From: Jeff King <peff@peff.net>
>
> Some systems do not have perl installed to /usr/bin. Use the variable
> from the build settiings, and call perl directly than via shebang.
>
> Signed-off-by: Max Kirillov <max@max630.net>
> ---
> Submitting. Could you sign-off? Also removed shebang from the script as it is not needed
Yep:
Signed-off-by: Jeff King <peff@peff.net>
As Carlos mentioned, I think you could leave the shebang as
documentation, but I'm OK either way.
-Peff
next prev parent reply other threads:[~2018-11-24 12:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:15 [PATCH] t5562: skip if NO_CURL is enabled Carlo Marcelo Arenas Belón
2018-11-19 10:42 ` Ævar Arnfjörð Bjarmason
2018-11-19 18:40 ` Max Kirillov
2018-11-19 19:36 ` Carlo Arenas
2018-11-19 21:26 ` Max Kirillov
2018-11-19 21:39 ` Jeff King
2018-11-22 23:38 ` [PATCH] t5562: fix perl path Max Kirillov
2018-11-23 14:31 ` Carlo Arenas
2018-11-24 12:10 ` Jeff King [this message]
2018-11-20 9:11 ` [PATCH] t5562: skip if NO_CURL is enabled Jeff King
2018-11-21 12:02 ` Carlo Arenas
2018-11-21 22:49 ` Max Kirillov
2018-11-21 23:36 ` Carlo Arenas
2018-11-22 1:04 ` Carlo Arenas
2018-11-22 6:37 ` Max Kirillov
2018-11-22 10:17 ` Carlo Arenas
2018-11-22 16:17 ` Jeff King
2018-11-22 23:43 ` Max Kirillov
2018-11-23 12:57 ` Carlo Arenas
2018-11-24 7:04 ` [PATCH] t5562: do not reuse output files Max Kirillov
2018-11-24 7:34 ` Junio C Hamano
2018-11-24 7:47 ` Junio C Hamano
2018-11-24 7:58 ` Max Kirillov
2018-11-24 9:37 ` [PATCH v3] " Max Kirillov
2018-11-24 12:14 ` [PATCH] " Jeff King
2018-11-24 13:03 ` Max Kirillov
2018-11-24 13:48 ` [PATCH] http-backend: enable cleaning up forked upload/receive-pack on exit Max Kirillov
2018-11-26 2:10 ` Junio C Hamano
2018-11-26 2:06 ` [PATCH] t5562: do not reuse output files Junio C Hamano
2018-11-28 4:17 ` Max Kirillov
2018-11-24 7:52 ` [PATCH v2] " Max Kirillov
2018-11-28 14:56 ` [PATCH] t5562: skip if NO_CURL is enabled Ævar Arnfjörð Bjarmason
2018-12-01 19:53 ` Jeff King
2018-11-28 13:27 ` SZEDER Gábor
2018-12-01 19:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181124121036.GC19257@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=max@max630.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.