From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Cc: loghyr@gmail.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] pynfs: fix result array access in CSID7
Date: Tue, 27 Nov 2018 15:14:50 -0500 [thread overview]
Message-ID: <20181127201450.GA12810@fieldses.org> (raw)
In-Reply-To: <20181126160827.153240-1-tigran.mkrtchyan@desy.de>
On Mon, Nov 26, 2018 at 05:08:27PM +0100, Tigran Mkrtchyan wrote:
> fixes 6612354e
>
> the result array look like
Thanks, applied.--b.
>
> ..., OPEN, GETFH, LAYOUTGET]
> thus fh in -2, open stateid in -3
>
> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
> ---
> nfs4.1/server41tests/st_current_stateid.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/nfs4.1/server41tests/st_current_stateid.py b/nfs4.1/server41tests/st_current_stateid.py
> index 58f6e9b..a6671eb 100644
> --- a/nfs4.1/server41tests/st_current_stateid.py
> +++ b/nfs4.1/server41tests/st_current_stateid.py
> @@ -147,12 +147,12 @@ def testOpenLayoutGet(t, env):
> sess = env.c1.new_pnfs_client_session(env.testname(t))
>
> open_op = open_create_file_op(sess, env.testname(t), open_create=OPEN4_CREATE)
> - res = sess.compound( open_op +
> + res = sess.compound( open_op +
> [op.layoutget(False, LAYOUT4_NFSV4_1_FILES, LAYOUTIOMODE4_RW,
> 0, 8192, 8192, current_stateid, 0xffff)])
> check(res, NFS4_OK)
> - fh = res.resarray[-1].object
> - stateid = res.resarray[-2].stateid
> + fh = res.resarray[-2].object
> + stateid = res.resarray[-3].stateid
> res = close_file(sess, fh, stateid=stateid)
> check(res)
>
> --
> 2.19.1
prev parent reply other threads:[~2018-11-27 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 16:08 [PATCH] pynfs: fix result array access in CSID7 Tigran Mkrtchyan
2018-11-27 20:14 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127201450.GA12810@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=loghyr@gmail.com \
--cc=tigran.mkrtchyan@desy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.