From: Christoph Hellwig <hch@infradead.org>
To: axboe@kernel.dk, bvanassche@acm.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v3] block: add documentation for io_timeout
Date: Wed, 5 Dec 2018 06:40:06 -0800 [thread overview]
Message-ID: <20181205144006.GA18123@infradead.org> (raw)
In-Reply-To: <20181205141701.GA33910@192.168.3.9>
Can you please also send a patch to not show this attribute for
drivers without a timeout handler? Thanks!
On Wed, Dec 05, 2018 at 10:17:06PM +0800, Weiping Zhang wrote:
> Add documentation for /sys/block/<disk>/queue/io_timeout.
>
> Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
> ---
> Documentation/ABI/testing/sysfs-block | 10 ++++++++++
> Documentation/block/queue-sysfs.txt | 7 +++++++
> 2 files changed, 17 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-block b/Documentation/ABI/testing/sysfs-block
> index dea212db9df3..f254a374710a 100644
> --- a/Documentation/ABI/testing/sysfs-block
> +++ b/Documentation/ABI/testing/sysfs-block
> @@ -271,3 +271,13 @@ Description:
> size of 512B sectors of the zones of the device, with
> the eventual exception of the last zone of the device
> which may be smaller.
> +
> +What: /sys/block/<disk>/queue/io_timeout
> +Date: November 2018
> +Contact: Weiping Zhang <zhangweiping@didiglobal.com>
> +Description:
> + io_timeout is a request’s timeouts at block layer in
> + milliseconds. When the underlying driver starts processing
> + a request, the generic block layer will start a timer, if
> + this request cannot be completed in io_timeout milliseconds,
> + a timeout event will occur.
> diff --git a/Documentation/block/queue-sysfs.txt b/Documentation/block/queue-sysfs.txt
> index 2c1e67058fd3..f0c9bbce73fd 100644
> --- a/Documentation/block/queue-sysfs.txt
> +++ b/Documentation/block/queue-sysfs.txt
> @@ -67,6 +67,13 @@ If set to a value larger than 0, the kernel will put the process issuing
> IO to sleep for this amont of microseconds before entering classic
> polling.
>
> +io_timeout (RW)
> +---------------
> +This is a request’s timeouts at block layer in milliseconds. When the
> +underlying driver starts processing a request, the generic block layer
> +will start a timer, if this request cannot be completed in io_timeout
> +milliseconds, a timeout event will occur.
> +
> iostats (RW)
> -------------
> This file is used to control (on/off) the iostats accounting of the
> --
> 2.14.1
>
---end quoted text---
next prev parent reply other threads:[~2018-12-05 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 14:17 [PATCH v3] block: add documentation for io_timeout Weiping Zhang
2018-12-05 14:40 ` Christoph Hellwig [this message]
2018-12-05 14:49 ` Weiping Zhang
2018-12-05 14:59 ` Weiping Zhang
2018-12-06 16:06 ` Bart Van Assche
2018-12-06 16:19 ` Christoph Hellwig
2018-12-06 16:19 ` Bart Van Assche
2018-12-26 1:51 ` Weiping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205144006.GA18123@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.