Re: [PATCH] ARM: shmobile: fix build regressions

From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Magnus Damm <magnus.damm@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Biju Das <biju.das@bp.renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: shmobile: fix build regressions
Date: Wed, 12 Dec 2018 11:30:33 +0100	[thread overview]
Message-ID: <20181212103032.ejjr6itnyb6uzck5@verge.net.au> (raw)
In-Reply-To: <CAMuHMdV9Xp6J0oiYxYn+5SxmqnOLX78rTts2E7dmH4xzLe_KTg@mail.gmail.com>

On Tue, Dec 11, 2018 at 09:58:05AM +0100, Geert Uytterhoeven wrote:
> Hi Arnd,
> 
> On Mon, Dec 10, 2018 at 10:00 PM Arnd Bergmann <arnd@arndb.de> wrote:
> > A number of Kconfig options have become available now to random ARM
> > platforms outside of ARCH_MULTIPLATFORM, which now causes Kconfig
> > warnings, and other build errors when those select options that
> > lack additonal dependencies, e.g.:
> >
> > WARNING: unmet direct dependencies detected for HAVE_ARM_ARCH_TIMER
> >   Depends on [n]: CPU_V7 [=n]
> >   Selected by [y]:
> >   - ARCH_RCAR_GEN2 [=y] && SOC_RENESAS [=y]
> >   - ARCH_R8A73A4 [=y] && SOC_RENESAS [=y] && ARM [=y]
> >
> > WARNING: unmet direct dependencies detected for SYS_SUPPORTS_EM_STI
> >   Depends on [n]: GENERIC_CLOCKEVENTS [=n]
> >   Selected by [y]:
> >   - ARCH_EMEV2 [=y] && SOC_RENESAS [=y] && ARM [=y]
> >
> > Put the old dependency on ARCH_RENESAS back for the moment to restore
> > the previous behavior.
> >
> > Fixes: 062887bf5ef7 ("ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/soc/renesas/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
> > index 4d8012e1205c..68bfca6f20dd 100644
> > --- a/drivers/soc/renesas/Kconfig
> > +++ b/drivers/soc/renesas/Kconfig
> > @@ -44,7 +44,7 @@ config ARCH_RZN1
> >         bool
> >         select ARM_AMBA
> >
> > -if ARM
> > +if ARM && ARCH_RENESAS
> 
> After a closer look, I think restricting this from ARM to ARCH_MULTI_V7
> should work, too (ARCH_MULTI_V7 selects CPU_V7, and ARCH_MULTIPLATFORM
> selects GENERIC_CLOCKEVENTS).

Hi Arnd,

what is your preferred way forwards here?
I'm tempted to take your patch as-is and then work on
refining the dependency as a follow-up.