From: Patchwork <patchwork@emeril.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Fix TypeC legacy HPD handling (rev2)
Date: Fri, 14 Dec 2018 19:17:58 -0000 [thread overview]
Message-ID: <20181214191758.6811.87117@emeril.freedesktop.org> (raw)
In-Reply-To: <20181214182703.18865-1-imre.deak@intel.com>
== Series Details ==
Series: drm/i915/icl: Fix TypeC legacy HPD handling (rev2)
URL : https://patchwork.freedesktop.org/series/54017/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
39a8e2bef8b8 drm/i915/icl: Add a debug print for TypeC port disconnection
-:29: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#29: FILE: drivers/gpu/drm/i915/intel_dp.c:5071:
+ static const char *names[] = {
total: 0 errors, 1 warnings, 0 checks, 65 lines checked
4038ff7e5289 drm/i915/bios: Parse the VBT TypeC and Thunderbolt port flags
-:43: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15)
#43: FILE: drivers/gpu/drm/i915/intel_bios.c:1389:
+ if (bdb_version >= 195)
+ info->supports_typec_usb = child->dp_usb_type_c;
total: 0 errors, 1 warnings, 0 checks, 25 lines checked
073e19935f67 drm/i915/icl: Fix HPD handling for TypeC legacy ports
-:270: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool bitfields as unsigned int or u<8|16|32>
#270: FILE: drivers/gpu/drm/i915/intel_drv.h:1237:
+ bool tc_legacy_port:1;
total: 0 errors, 1 warnings, 0 checks, 188 lines checked
4b9db3b474f7 drm/i915/icl: Add fallback detection method for TypeC legacy ports
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-14 19:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 18:26 [PATCH v2 0/4] drm/i915/icl: Fix TypeC Legacy HPD handling Imre Deak
2018-12-14 18:27 ` [PATCH v2 1/4] drm/i915/icl: Add a debug print for TypeC port disconnection Imre Deak
2018-12-14 18:27 ` [PATCH v2 2/4] drm/i915/bios: Parse the VBT TypeC and Thunderbolt port flags Imre Deak
2018-12-17 20:49 ` Rodrigo Vivi
2018-12-14 18:27 ` [PATCH v2 3/4] drm/i915/icl: Fix HPD handling for TypeC legacy ports Imre Deak
2018-12-17 18:05 ` Rodrigo Vivi
2018-12-17 19:35 ` Imre Deak
2018-12-17 20:49 ` Rodrigo Vivi
2018-12-14 18:27 ` [PATCH v2 4/4] drm/i915/icl: Add fallback detection method " Imre Deak
2018-12-18 11:05 ` Kahola, Mika
2018-12-14 19:17 ` Patchwork [this message]
2018-12-14 19:19 ` ✗ Fi.CI.SPARSE: warning for drm/i915/icl: Fix TypeC legacy HPD handling (rev2) Patchwork
2018-12-14 19:36 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-14 21:28 ` ✓ Fi.CI.IGT: " Patchwork
2018-12-18 15:12 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214191758.6811.87117@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.