From: Kalle Valo <kvalo@codeaurora.org>
To: Bhagavathi Perumal S <bperumal@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Bhagavathi Perumal S <bperumal@codeaurora.org>
Subject: Re: [PATCH] ath10k: Fix warning due to msdu limit error
Date: Thu, 20 Dec 2018 17:02:51 +0000 (UTC) [thread overview]
Message-ID: <20181220170258.2E58E60A3B@smtp.codeaurora.org> (raw)
In-Reply-To: <1542613703-9704-1-git-send-email-bperumal@codeaurora.org>
Bhagavathi Perumal S <bperumal@codeaurora.org> wrote:
> Some hardwares variants (QCA99x0) are limiting msdu deaggregation with
> some threshold value(default limit in QCA99x0 is 64 msdus), it was introduced to
> avoid excessive MSDU-deaggregation in error cases. When number of sub frames
> exceeds the limit, target hardware will send all msdus starting from present
> msdu in RAW format as a single msdu packet and it will be indicated with
> error status bit "RX_MSDU_END_INFO0_MSDU_LIMIT_ERR" set in rx descriptor.
> This msdu frame is a partial raw MSDU and does't have first msdu and ieee80211
> header. It caused below warning message.
>
> [ 320.151332] ------------[ cut here ]------------
> [ 320.155006] WARNING: CPU: 0 PID: 3 at drivers/net/wireless/ath/ath10k/htt_rx.c:1188
>
> In our issue case, MSDU limit error happened due to FCS error and generated
> this warning message.
>
> This fixes the warning by handling the MSDU limit error. If msdu limit error
> happens, driver adds first MSDU's ieee80211 header and sets A-MSDU present bit
> in QOS header so that upper layer processes this frame if it is valid or drop it
> if FCS error set. And removed the warning message, hence partial msdus without
> first msdu is expected in msdu limit error cases.
>
> Tested on QCA9984, Firmware 10.4-3.6-00104
>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
a2864772f33a ath10k: fix warning due to msdu limit error
--
https://patchwork.kernel.org/patch/10688251/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-12-20 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 7:48 [PATCH] ath10k: Fix warning due to msdu limit error Bhagavathi Perumal S
2018-11-19 7:48 ` Bhagavathi Perumal S
2018-12-20 12:09 ` Kalle Valo
2018-12-20 12:09 ` Kalle Valo
2018-12-20 17:02 ` Kalle Valo
2018-12-20 17:02 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220170258.2E58E60A3B@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=bperumal@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.