From: maximilian attems <maks@stro.at>
To: riku.voipio@linaro.org
Cc: Ben Hutchings <ben@decadent.org.uk>,
linux-kbuild@vger.kernel.org, yamada.masahiro@socionext.com,
manivannan.sadhasivam@linaro.org, debian-kernel@lists.debian.org
Subject: Re: [PATCH v2] deb-pkg: generate correct build dependencies
Date: Wed, 2 Jan 2019 20:52:41 +0100 [thread overview]
Message-ID: <20190102195240.GA9246@gravitino> (raw)
In-Reply-To: <f1334713b98ce0133988f5ff590ee90b81cf30d9.camel@decadent.org.uk>
On Wed, Jan 02, 2019 at 07:48:12PM +0000, Ben Hutchings wrote:
> On Wed, 2019-01-02 at 11:23 +0200, riku.voipio@linaro.org wrote:
> > From: Riku Voipio <riku.voipio@linaro.org>
> >
> > bison/flex is now needed always for building for kconfig. Some build
> > dependencies depend on kernel configuration, enable them as needed:
> >
> > - libelf-dev when UNWINDER_ORC is set
> > - libssl-dev for SYSTEM_TRUSTED_KEYRING
> >
> > Since the libssl-dev is needed for extract_cert binary, denote with
> > :native to install the libssl-dev for the build machines
> > architecture,
> > rather than for the architecture of the kernel being built.
> >
> > Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
>
> Reviewed-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: maximilian attems <maks@stro.at>
> > ---
> > v2: commit message updated
> > ---
> > scripts/package/mkdebian | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> > index edcad61fe3cd..c858abf4569e 100755
> > --- a/scripts/package/mkdebian
> > +++ b/scripts/package/mkdebian
> > @@ -134,6 +134,8 @@ fi
> >
> > mkdir -p debian/
> > echo $debarch > debian/arch
> > +extra_build_depends=", $(if_enabled_echo UNWINDER_ORC libelf-dev)"
> > +extra_build_depends="$extra_build_depends, $(if_enabled_echo SYSTEM_TRUSTED_KEYRING libssl-dev:native)"
> >
> > # Generate a simple changelog template
> > cat <<EOF > debian/changelog
> > @@ -170,7 +172,7 @@ Source: $sourcename
> > Section: kernel
> > Priority: optional
> > Maintainer: $maintainer
> > -Build-Depends: bc, kmod, cpio
> > +Build-Depends: bc, kmod, cpio, bison, flex $extra_build_depends
> > Homepage: http://www.kernel.org/
> >
> > Package: $packagename
> --
> Ben Hutchings
> Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer
>
>
next prev parent reply other threads:[~2019-01-02 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 9:23 [PATCH v2] deb-pkg: generate correct build dependencies riku.voipio
2019-01-02 19:48 ` Ben Hutchings
2019-01-02 19:52 ` maximilian attems [this message]
2019-01-02 21:28 ` Masahiro Yamada
2019-02-18 16:00 ` Masahiro Yamada
2019-02-18 17:05 ` Masahiro Yamada
2019-02-18 17:54 ` Ben Hutchings
2019-02-18 17:58 ` Ben Hutchings
2019-02-19 2:15 ` Masahiro Yamada
2019-02-20 3:41 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190102195240.GA9246@gravitino \
--to=maks@stro.at \
--cc=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=riku.voipio@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.