From: Patchwork <patchwork@emeril.freedesktop.org>
To: Lyude Paul <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup (rev4)
Date: Sat, 05 Jan 2019 00:44:23 -0000 [thread overview]
Message-ID: <20190105004423.19476.96260@emeril.freedesktop.org> (raw)
In-Reply-To: <20190105001506.30181-1-lyude@redhat.com>
== Series Details ==
Series: MST refcounting/atomic helpers cleanup (rev4)
URL : https://patchwork.freedesktop.org/series/54030/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2a2093f380b0 drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends
-:84: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#84: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:990:
+ rmstb = drm_dp_mst_topology_get_mstb_validated_locked(
-:102: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#102: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1006:
+ rmstb = drm_dp_mst_topology_get_mstb_validated_locked(
-:150: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#150: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1373:
+ mstb_child = drm_dp_mst_topology_get_mstb_validated(
total: 0 errors, 0 warnings, 3 checks, 399 lines checked
395ddef17891 drm/dp_mst: Introduce new refcounting scheme for mstbs and ports
-:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27:
commit 263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")
-:51: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")'
#51:
commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")
-:136: WARNING:BAD_SIGN_OFF: Duplicate signature
#136:
Signed-off-by: Lyude Paul <lyude@redhat.com>
-:139: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#139:
new file mode 100644
-:844: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#844: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1329:
+ mport = drm_dp_mst_topology_get_port_validated_locked(
-:858: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#858: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1346:
+ rport = drm_dp_mst_topology_get_port_validated_locked(
total: 1 errors, 3 warnings, 2 checks, 975 lines checked
a20c087d93b3 drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails
42483b36cce0 drm/dp_mst: Stop releasing VCPI when removing ports from topology
922a91cd84d2 drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs
-:97: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#97: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2276:
+ port = drm_dp_mst_topology_get_port_validated(
total: 0 errors, 0 warnings, 1 checks, 124 lines checked
c9b9ef293e41 drm/i915: Keep malloc references to MST ports
5dbb33b4a196 drm/amdgpu/display: Keep malloc ref to MST port
90a9631dfbe1 drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()
03cee9c12c05 drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()
0d5dc5d62fd6 drm/nouveau: Keep malloc references to MST ports
81af58e1850c drm/nouveau: Stop unsetting mstc->port, use malloc refs
b6f6bbe3d1bc drm/nouveau: Grab payload lock in nv50_msto_payload()
42197be73f27 drm/dp_mst: Add some atomic state iterator macros
-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:710:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))
-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:710:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))
-:112: WARNING:LONG_LINE: line over 100 characters
#112: FILE: include/drm/drm_dp_mst_helper.h:712:
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))
-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:727:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))
-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:727:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))
-:129: WARNING:LONG_LINE: line over 100 characters
#129: FILE: include/drm/drm_dp_mst_helper.h:729:
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))
-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:745:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))
-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:745:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))
-:147: WARNING:LONG_LINE: line over 100 characters
#147: FILE: include/drm/drm_dp_mst_helper.h:747:
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))
total: 0 errors, 3 warnings, 6 checks, 120 lines checked
31f003c7f24b drm/dp_mst: Start tracking per-port VCPI allocations
-:42: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#42:
* Add some missing changes that were requested by danvet that I forgot about after
total: 0 errors, 1 warnings, 0 checks, 444 lines checked
7e8e5b7e31ad drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()
b2223e97312f drm/nouveau: Use atomic VCPI helpers for MST
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-05 0:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 0:14 [PATCH v4 00/16] MST refcounting/atomic helpers cleanup Lyude Paul
2019-01-05 0:14 ` [PATCH v4 01/16] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends Lyude Paul
2019-01-05 0:15 ` [PATCH v4 10/16] drm/nouveau: Keep malloc references to MST ports Lyude Paul
2019-01-05 0:15 ` [PATCH v4 11/16] drm/nouveau: Stop unsetting mstc->port, use malloc refs Lyude Paul
[not found] ` <20190105001506.30181-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-05 0:14 ` [PATCH v4 02/16] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports Lyude Paul
2019-01-08 19:00 ` Wentland, Harry
2019-01-05 0:14 ` [PATCH v4 03/16] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails Lyude Paul
2019-01-05 0:14 ` [PATCH v4 04/16] drm/dp_mst: Stop releasing VCPI when removing ports from topology Lyude Paul
2019-01-05 0:14 ` [PATCH v4 05/16] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs Lyude Paul
2019-01-05 0:14 ` [PATCH v4 06/16] drm/i915: Keep malloc references to MST ports Lyude Paul
2019-01-05 0:14 ` [PATCH v4 07/16] drm/amdgpu/display: Keep malloc ref to MST port Lyude Paul
2019-01-05 0:14 ` [PATCH v4 08/16] drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector() Lyude Paul
2019-01-05 0:14 ` [PATCH v4 09/16] drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup() Lyude Paul
2019-01-05 0:15 ` [PATCH v4 12/16] drm/nouveau: Grab payload lock in nv50_msto_payload() Lyude Paul
2019-01-05 0:15 ` [PATCH v4 14/16] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
2019-01-05 0:15 ` [PATCH v4 15/16] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check() Lyude Paul
2019-01-08 19:57 ` [PATCH v4 00/16] MST refcounting/atomic helpers cleanup Wentland, Harry
[not found] ` <a297d81b-f4e2-84ea-1c06-cf38d336ac6c-5C7GfCeVMHo@public.gmane.org>
2019-01-08 21:04 ` Lyude Paul
2019-01-05 0:15 ` [PATCH v4 13/16] drm/dp_mst: Add some atomic state iterator macros Lyude Paul
2019-01-05 0:15 ` [PATCH v4 16/16] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2019-01-05 0:44 ` Patchwork [this message]
2019-01-05 0:49 ` ✗ Fi.CI.SPARSE: warning for MST refcounting/atomic helpers cleanup (rev4) Patchwork
2019-01-05 1:01 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-05 2:33 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190105004423.19476.96260@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lyude@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.