From: "Gonzalez, Alex" <Alex.Gonzalez@digi.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: goodix - decouple irq and reset lines
Date: Mon, 7 Jan 2019 16:42:26 +0000 [thread overview]
Message-ID: <20190107164225.GA5394@agonzal-linux> (raw)
In-Reply-To: <6b8f757eb52eb74d9dc2c3bedbfec798a58c0ec2.camel@hadess.net>
Hi Bastien,
>Given that we do have access to the datasheet, it would also be useful
>for the patch to mention where in the datasheet it says that the reset
>line can be left pulled-up,
The pin description table on section 4, on the "Reset pin" row, contains a
remark as follows:
External 10K pull-up resistor required, active-low reset
This comes from a newer revision of the datasheet though:
http://focuslcds.com/content/GT911.pdf
I guess it's open to interpretation whether driving the reset line is
optional. The code seemed to imply it by using devm_gpiod_get_optional() to
obtain the GPIO.
>or mention on which shipping device this
>setup is already used (and if so, what the DTS or ACPI snippet that
>declares those is).
>
I am testing with an LCD application kit for the ConnectCore 6UL SBC Pro:
https://www.digi.com/products/models/cc-acc-lcdw-10
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts?h=v5.0-rc1#n120
This display in particular does not have the reset line available on the
connector. The only way to make it work seems to be to use the INT line to fix
an I2C address.
>Cheers
>
next prev parent reply other threads:[~2019-01-07 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 16:00 [PATCH] Input: goodix - decouple irq and reset lines Alex Gonzalez
2019-01-04 16:00 ` Alex Gonzalez
2019-01-04 16:00 ` Alex Gonzalez
2019-01-04 16:00 ` Alex Gonzalez
2019-01-04 22:31 ` Andreas Gohr
2019-01-05 22:51 ` Dmitry Torokhov
2019-01-07 10:13 ` Gonzalez, Alex
2019-01-07 15:56 ` Bastien Nocera
2019-01-07 16:01 ` Bastien Nocera
2019-01-07 16:44 ` Gonzalez, Alex
2019-01-07 16:42 ` Gonzalez, Alex [this message]
2019-01-07 18:56 ` Dmitry Torokhov
2019-01-08 17:20 ` Gonzalez, Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107164225.GA5394@agonzal-linux \
--to=alex.gonzalez@digi.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.