All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: Jerry Zuo <Jerry.Zuo@amd.com>, David Airlie <airlied@redhat.com>,
	Juston Li <juston.li@intel.com>
Subject: [PATCH v5 00/20] MST refcounting/atomic helpers cleanup
Date: Tue,  8 Jan 2019 19:34:57 -0500	[thread overview]
Message-ID: <20190109003516.14752-1-lyude@redhat.com> (raw)

This is the series I've been working on for a while now to get all of
the atomic DRM drivers in the tree to use the atomic MST helpers, and to
make the atomic MST helpers actually idempotent. Turns out it's a lot
more difficult to do that without also fixing how port and branch device
refcounting works so that it actually makes sense, since the current
upstream implementation requires a ton of magic in the atomic helpers to
work around properly and in many situations just plain doesn't work as
intended.

There's still more cleanup that can be done, but I think this is a good
place to start off for now :).

Also available on gitlab:

https://gitlab.freedesktop.org/lyudess/linux/commits/wip/mst-dual-kref-start-v5

Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@redhat.com>
Cc: Jerry Zuo <Jerry.Zuo@amd.com>
Cc: Juston Li <juston.li@intel.com>

Lyude Paul (20):
  drm/dp_mst: Fix some formatting in drm_dp_add_port()
  drm/dp_mst: Fix some formatting in drm_dp_payload_send_msg()
  drm/dp_mst: Fix some formatting in drm_dp_mst_allocate_vcpi()
  drm/dp_mst: Fix some formatting in drm_dp_mst_deallocate_vcpi()
  drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and
    friends
  drm/dp_mst: Introduce new refcounting scheme for mstbs and ports
  drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref
    fails
  drm/dp_mst: Stop releasing VCPI when removing ports from topology
  drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs
  drm/i915: Keep malloc references to MST ports
  drm/amdgpu/display: Keep malloc ref to MST port
  drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()
  drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()
  drm/nouveau: Keep malloc references to MST ports
  drm/nouveau: Stop unsetting mstc->port, use malloc refs
  drm/nouveau: Grab payload lock in nv50_msto_payload()
  drm/dp_mst: Add some atomic state iterator macros
  drm/dp_mst: Start tracking per-port VCPI allocations
  drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()
  drm/nouveau: Use atomic VCPI helpers for MST

 .../gpu/dp-mst/topology-figure-1.dot          |  52 +
 .../gpu/dp-mst/topology-figure-2.dot          |  56 +
 .../gpu/dp-mst/topology-figure-3.dot          |  59 ++
 Documentation/gpu/drm-kms-helpers.rst         |  26 +-
 .../display/amdgpu_dm/amdgpu_dm_mst_types.c   |  11 +-
 drivers/gpu/drm/drm_dp_mst_topology.c         | 955 ++++++++++++++----
 drivers/gpu/drm/i915/intel_connector.c        |   4 +
 drivers/gpu/drm/i915/intel_display.c          |   4 +
 drivers/gpu/drm/i915/intel_dp_mst.c           |  55 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c       |  96 +-
 include/drm/drm_dp_mst_helper.h               | 151 ++-
 11 files changed, 1213 insertions(+), 256 deletions(-)
 create mode 100644 Documentation/gpu/dp-mst/topology-figure-1.dot
 create mode 100644 Documentation/gpu/dp-mst/topology-figure-2.dot
 create mode 100644 Documentation/gpu/dp-mst/topology-figure-3.dot

-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2019-01-09  0:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09  0:34 Lyude Paul [this message]
     [not found] ` <20190109003516.14752-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-09  0:34   ` [PATCH v5 01/20] drm/dp_mst: Fix some formatting in drm_dp_add_port() Lyude Paul
2019-01-09  0:34   ` [PATCH v5 02/20] drm/dp_mst: Fix some formatting in drm_dp_payload_send_msg() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 03/20] drm/dp_mst: Fix some formatting in drm_dp_mst_allocate_vcpi() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 04/20] drm/dp_mst: Fix some formatting in drm_dp_mst_deallocate_vcpi() Lyude Paul
     [not found]     ` <20190109003516.14752-5-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:16       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 05/20] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends Lyude Paul
2019-01-09  0:35   ` [PATCH v5 06/20] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports Lyude Paul
     [not found]     ` <20190109003516.14752-7-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:12       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 07/20] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails Lyude Paul
     [not found]     ` <20190109003516.14752-8-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:16       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 08/20] drm/dp_mst: Stop releasing VCPI when removing ports from topology Lyude Paul
2019-01-10  9:17     ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 09/20] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs Lyude Paul
2019-01-09  0:35   ` [PATCH v5 10/20] drm/i915: Keep malloc references to MST ports Lyude Paul
2019-01-09  0:35   ` [PATCH v5 12/20] drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 13/20] drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 14/20] drm/nouveau: Keep malloc references to MST ports Lyude Paul
2019-01-09  0:35   ` [PATCH v5 15/20] drm/nouveau: Stop unsetting mstc->port, use malloc refs Lyude Paul
2019-01-09  0:35   ` [PATCH v5 16/20] drm/nouveau: Grab payload lock in nv50_msto_payload() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 17/20] drm/dp_mst: Add some atomic state iterator macros Lyude Paul
2019-01-10  9:28     ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 18/20] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
     [not found]     ` <20190109003516.14752-19-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:35       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 19/20] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check() Lyude Paul
     [not found]     ` <20190109003516.14752-20-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:35       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 20/20] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2019-01-09  0:35 ` [PATCH v5 11/20] drm/amdgpu/display: Keep malloc ref to MST port Lyude Paul
2019-01-09  0:54 ` ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup (rev5) Patchwork
2019-01-09  1:15 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-09 10:45 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190109003516.14752-1-lyude@redhat.com \
    --to=lyude@redhat.com \
    --cc=Jerry.Zuo@amd.com \
    --cc=airlied@redhat.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=juston.li@intel.com \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.