From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Marc Dionne <marc.c.dionne@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
x86@kernel.org
Subject: Re: x86/fpu: Don't export __kernel_fpu_{begin,end}()
Date: Thu, 10 Jan 2019 14:11:32 +0100 [thread overview]
Message-ID: <20190110131132.GC20217@kroah.com> (raw)
In-Reply-To: <20190109170935.e6b6rwzpk6dlruu4@linutronix.de>
On Wed, Jan 09, 2019 at 06:09:35PM +0100, Sebastian Andrzej Siewior wrote:
> On 2019-01-09 17:52:35 [+0100], Greg Kroah-Hartman wrote:
> > If there are no in-kernel users, the symbols should not be exported
> > anymore. That's nothing new, we have always done this.
>
> The thing is that we had
> EXPORT_SYMBOL(__kernel_fpu_begin)
> EXPORT_SYMBOL_GPL(kernel_fpu_begin)
>
> and now __kernel_fpu_begin() is no longer exported and static only.
Ok, that is fine.
> All in kernel user (including the kvm module) use kernel_fpu_begin()
> which is not available to proprietary modules. Hence Marc's mail.
But since when did out-of-tree modules use __kernel_fpu_begin? It's an
x86-only thing, and shouldn't really be used by anyone, right?
> > > On the other hand could we just drop EXPORT_SYMBOL_GPL? I doubt this
> > > helps in any way yet please correct me if I am wrong.
> >
> > Yes, it helps, please leave it as-is.
>
> As you say. I only notice that certain things used to work and then no
> longer do because due to $rework it somehow become EXPORT_SYMBOL_GPL
> only and people complain and we tend to switch the export back to
> EXPORT_SYMBOL.
That is a different topic than the whole _GPL symbol export at all.
Please don't conflate the two.
> I'm not aware of a case where it actually helped in anyway.
The use of the _GPL symbol exports has helped in numerous places over
the years. I'd be glad to discuss details over a beverage sometime :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-01-10 13:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <git-mailbomb-linux-master-12209993e98c5fa1855c467f22a24e3d5b8be205@kernel.org>
2019-01-07 22:08 ` x86/fpu: Don't export __kernel_fpu_{begin,end}() Marc Dionne
2019-01-09 11:19 ` Sebastian Andrzej Siewior
2019-01-09 16:52 ` Greg Kroah-Hartman
2019-01-09 17:09 ` Sebastian Andrzej Siewior
2019-01-09 17:40 ` Marc Dionne
2019-01-10 13:13 ` Greg Kroah-Hartman
2019-01-10 13:11 ` Greg Kroah-Hartman [this message]
2019-01-10 17:32 ` Hutter, Tony
2019-01-10 18:07 ` Sebastian Andrzej Siewior
2019-01-10 18:24 ` Greg Kroah-Hartman
2019-01-11 3:18 ` Kash Pande
2019-01-11 5:04 ` Lukas Wunner
2019-01-11 5:40 ` Greg Kroah-Hartman
2019-01-11 18:06 ` Lukas Wunner
2019-01-23 15:58 ` Pavel Machek
2019-01-15 13:01 ` Rene Schickbauer
2019-01-15 13:32 ` Christoph Hellwig
2019-01-15 13:42 ` Greg Kroah-Hartman
2019-01-15 18:51 ` Kash Pande
2019-01-21 12:30 ` Stephan von Krawczynski
2019-01-15 18:26 ` Kash Pande
2019-01-11 3:07 Kash Pande
[not found] <20190111054058.GA27966 () kroah ! com>
2019-01-11 6:24 ` Kash Pande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110131132.GC20217@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.c.dionne@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.