From: Jonathan Tan <jonathantanmy@google.com>
To: gitster@pobox.com
Cc: steadmon@google.com, jonathantanmy@google.com,
git@vger.kernel.org, avarab@gmail.com
Subject: Re: [PATCH] upload-pack: teach deepen-relative in protocol v2
Date: Thu, 10 Jan 2019 13:28:57 -0800 [thread overview]
Message-ID: <20190110212857.58772-1-jonathantanmy@google.com> (raw)
In-Reply-To: <xmqqr2dk1bxf.fsf@gitster-ct.c.googlers.com>
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Josh Steadmon <steadmon@google.com> writes:
> >
> >> Looks good to me.
> >> Reviewed-by: Josh Steadmon <steadmon@google.com>
> >
> > Thanks, both.
>
> This, when applied on top of ecbdaf08991, seems to break t5702.30,
> at least for me.
>
> Tip of 'pu' in today's push-out will be broken as it has this patch
> merged.
>
> Can somebody take a look?
I can reproduce this. I'll investigate this further. In the meantime,
feel free to remove this from pu.
next prev parent reply other threads:[~2019-01-10 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 21:24 [PATCH] upload-pack: teach deepen-relative in protocol v2 Jonathan Tan
2019-01-09 19:35 ` Josh Steadmon
2019-01-10 18:30 ` Junio C Hamano
2019-01-10 20:43 ` Junio C Hamano
2019-01-10 21:28 ` Jonathan Tan [this message]
2019-01-10 22:11 ` Jonathan Tan
2019-01-10 22:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110212857.58772-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.