From: Patchwork <patchwork@emeril.freedesktop.org>
To: Lyude Paul <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup (rev7)
Date: Fri, 11 Jan 2019 01:02:26 -0000 [thread overview]
Message-ID: <20190111010226.29238.2619@emeril.freedesktop.org> (raw)
In-Reply-To: <20190111005343.17443-1-lyude@redhat.com>
== Series Details ==
Series: MST refcounting/atomic helpers cleanup (rev7)
URL : https://patchwork.freedesktop.org/series/54030/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
4dc81bd3d040 drm/dp_mst: Fix some formatting in drm_dp_add_port()
5613e665e2e0 drm/dp_mst: Fix some formatting in drm_dp_payload_send_msg()
bab922f7f6c4 drm/dp_mst: Fix some formatting in drm_dp_mst_allocate_vcpi()
3e64f7a83561 drm/dp_mst: Fix some formatting in drm_dp_mst_deallocate_vcpi()
48650b1b91ef drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends
-:84: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#84: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:990:
+ rmstb = drm_dp_mst_topology_get_mstb_validated_locked(
-:102: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#102: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1006:
+ rmstb = drm_dp_mst_topology_get_mstb_validated_locked(
-:150: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#150: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1379:
+ mstb_child = drm_dp_mst_topology_get_mstb_validated(
total: 0 errors, 0 warnings, 3 checks, 401 lines checked
f3167088bed1 drm/dp_mst: Introduce new refcounting scheme for mstbs and ports
-:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27:
commit 263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")
-:51: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")'
#51:
commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")
-:142: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#142:
new file mode 100644
-:848: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#848: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1330:
+ mport = drm_dp_mst_topology_get_port_validated_locked(
-:862: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#862: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1347:
+ rport = drm_dp_mst_topology_get_port_validated_locked(
total: 1 errors, 2 warnings, 2 checks, 916 lines checked
33ed2b8bf69c drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails
5432def72627 drm/dp_mst: Stop releasing VCPI when removing ports from topology
f44216dab40f drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs
-:97: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#97: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2269:
+ port = drm_dp_mst_topology_get_port_validated(
total: 0 errors, 0 warnings, 1 checks, 124 lines checked
1215e951d338 drm/i915: Keep malloc references to MST ports
1659ca4c5976 drm/amdgpu/display: Keep malloc ref to MST port
e22b33d521e3 drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()
-:13: WARNING:BAD_SIGN_OFF: 'Reviewed-by:' is the preferred signature form
#13:
Reviewed-By: Ben Skeggs <bskeggs@redhat.com>
total: 0 errors, 1 warnings, 0 checks, 12 lines checked
fa65fc6573ef drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()
-:20: WARNING:BAD_SIGN_OFF: 'Reviewed-by:' is the preferred signature form
#20:
Reviewed-By: Ben Skeggs <bskeggs@redhat.com>
total: 0 errors, 1 warnings, 0 checks, 23 lines checked
f6bc6e58cb36 drm/nouveau: Keep malloc references to MST ports
-:19: WARNING:BAD_SIGN_OFF: 'Reviewed-by:' is the preferred signature form
#19:
Reviewed-By: Ben Skeggs <bskeggs@redhat.com>
total: 0 errors, 1 warnings, 0 checks, 25 lines checked
fb2916eaf801 drm/nouveau: Stop unsetting mstc->port, use malloc refs
-:12: WARNING:BAD_SIGN_OFF: 'Reviewed-by:' is the preferred signature form
#12:
Reviewed-By: Ben Skeggs <bskeggs@redhat.com>
total: 0 errors, 1 warnings, 0 checks, 54 lines checked
9d1a374f3b0a drm/nouveau: Grab payload lock in nv50_msto_payload()
-:12: WARNING:BAD_SIGN_OFF: 'Reviewed-by:' is the preferred signature form
#12:
Reviewed-By: Ben Skeggs <bskeggs@redhat.com>
total: 0 errors, 1 warnings, 0 checks, 25 lines checked
9f0550204390 drm/dp_mst: Add some atomic state iterator macros
-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:711:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))
-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:711:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))
-:112: WARNING:LONG_LINE: line over 100 characters
#112: FILE: include/drm/drm_dp_mst_helper.h:713:
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))
-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:728:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))
-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:728:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))
-:129: WARNING:LONG_LINE: line over 100 characters
#129: FILE: include/drm/drm_dp_mst_helper.h:730:
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))
-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:746:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))
-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:746:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))
-:147: WARNING:LONG_LINE: line over 100 characters
#147: FILE: include/drm/drm_dp_mst_helper.h:748:
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))
total: 0 errors, 3 warnings, 6 checks, 120 lines checked
6dc4e60a7f77 drm/dp_mst: Start tracking per-port VCPI allocations
-:45: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#45:
* Cleanup atomic check logic for VCPI allocations - all we need to check in
total: 0 errors, 1 warnings, 0 checks, 444 lines checked
96f08bd75cd3 drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()
7058ad33b999 drm/nouveau: Use atomic VCPI helpers for MST
-:25: WARNING:BAD_SIGN_OFF: 'Reviewed-by:' is the preferred signature form
#25:
Reviewed-By: Ben Skeggs <bskeggs@redhat.com>
total: 0 errors, 1 warnings, 0 checks, 82 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-11 1:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 0:53 [PATCH v7 00/20] MST refcounting/atomic helpers cleanup Lyude Paul
2019-01-11 0:53 ` [PATCH v7 03/20] drm/dp_mst: Fix some formatting in drm_dp_mst_allocate_vcpi() Lyude Paul
2019-01-11 0:53 ` [PATCH v7 09/20] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs Lyude Paul
2019-01-11 0:53 ` [PATCH v7 12/20] drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector() Lyude Paul
[not found] ` <20190111005343.17443-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-11 0:53 ` [PATCH v7 01/20] drm/dp_mst: Fix some formatting in drm_dp_add_port() Lyude Paul
2019-01-11 0:53 ` [PATCH v7 02/20] drm/dp_mst: Fix some formatting in drm_dp_payload_send_msg() Lyude Paul
2019-01-11 0:53 ` [PATCH v7 04/20] drm/dp_mst: Fix some formatting in drm_dp_mst_deallocate_vcpi() Lyude Paul
2019-01-11 0:53 ` [PATCH v7 05/20] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends Lyude Paul
2019-01-11 0:53 ` [PATCH v7 06/20] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports Lyude Paul
2019-01-11 0:53 ` [PATCH v7 07/20] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails Lyude Paul
2019-01-11 0:53 ` [PATCH v7 08/20] drm/dp_mst: Stop releasing VCPI when removing ports from topology Lyude Paul
2019-01-11 0:53 ` [PATCH v7 10/20] drm/i915: Keep malloc references to MST ports Lyude Paul
2019-01-11 0:53 ` [PATCH v7 11/20] drm/amdgpu/display: Keep malloc ref to MST port Lyude Paul
2019-01-11 0:53 ` [PATCH v7 13/20] drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup() Lyude Paul
2019-01-11 0:53 ` [PATCH v7 14/20] drm/nouveau: Keep malloc references to MST ports Lyude Paul
2019-01-11 0:53 ` [PATCH v7 15/20] drm/nouveau: Stop unsetting mstc->port, use malloc refs Lyude Paul
2019-01-11 0:53 ` [PATCH v7 16/20] drm/nouveau: Grab payload lock in nv50_msto_payload() Lyude Paul
2019-01-11 0:53 ` [PATCH v7 17/20] drm/dp_mst: Add some atomic state iterator macros Lyude Paul
2019-01-11 0:53 ` [PATCH v7 18/20] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
2019-01-11 0:53 ` [PATCH v7 19/20] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check() Lyude Paul
2019-01-11 0:53 ` [PATCH v7 20/20] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2019-01-11 1:02 ` Patchwork [this message]
2019-01-11 1:26 ` ✓ Fi.CI.BAT: success for MST refcounting/atomic helpers cleanup (rev7) Patchwork
2019-01-11 11:41 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111010226.29238.2619@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lyude@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.