From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <willy@infradead.org>,
Toshi Kani <toshi.kani@hpe.com>, Boaz Harrosh <boazh@netapp.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH] mm: align anon mmap for THP
Date: Mon, 14 Jan 2019 16:50:02 +0300 [thread overview]
Message-ID: <20190114135001.w2wpql53zitellus@kshutemo-mobl1> (raw)
In-Reply-To: <ebd57b51-117b-4a3d-21d9-fc0287f437d6@oracle.com>
On Fri, Jan 11, 2019 at 03:28:37PM -0800, Mike Kravetz wrote:
> Ok, I just wanted to ask the question. I've seen application code doing
> the 'mmap sufficiently large area' then unmap to get desired alignment
> trick. Was wondering if there was something we could do to help.
Application may want to get aligned allocation for different reasons.
It should be okay for userspace to ask for size + (alignment - PAGE_SIZE)
and then round up the address to get the alignment. We basically do the
same on kernel side.
For THP, I believe, kernel already does The Right Thing™ for most users.
User still may want to get speific range as THP (to avoid false sharing or
something). But still I believe userspace has all required tools to get it
right.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2019-01-14 13:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 20:10 [RFC PATCH] mm: align anon mmap for THP Mike Kravetz
2019-01-11 21:55 ` Kirill A. Shutemov
2019-01-11 23:28 ` Mike Kravetz
2019-01-14 13:50 ` Kirill A. Shutemov [this message]
2019-01-14 16:29 ` Harrosh, Boaz
2019-01-14 16:40 ` Michal Hocko
2019-01-14 16:54 ` Harrosh, Boaz
2019-01-14 18:02 ` Michal Hocko
2019-01-14 15:35 ` Steven Sistare
2019-01-14 16:40 ` Harrosh, Boaz
2019-01-14 18:54 ` Mike Kravetz
2019-01-14 19:26 ` Steven Sistare
2019-01-15 8:24 ` Kirill A. Shutemov
2019-01-15 18:08 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114135001.w2wpql53zitellus@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=boazh@netapp.com \
--cc=dan.j.williams@intel.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=toshi.kani@hpe.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.