All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: mst@redhat.com, laurent@vivier.eu, imammedo@redhat.com,
	Wei Yang <richardw.yang@linux.intel.com>
Subject: [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin()
Date: Tue, 29 Jan 2019 08:08:19 +0800	[thread overview]
Message-ID: <20190129000820.31190-3-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190129000820.31190-1-richardw.yang@linux.intel.com>

Function acpi_table_add_builtin() is not used anymore.

Remove the definition and declaration.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 hw/acpi/core.c         | 6 ------
 include/hw/acpi/acpi.h | 1 -
 2 files changed, 7 deletions(-)

diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index d6f0709691..e9b1a85e54 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -305,12 +305,6 @@ out:
 
 static bool acpi_table_builtin = false;
 
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
-{
-    acpi_table_builtin = true;
-    acpi_table_add(opts, errp);
-}
-
 unsigned acpi_table_len(void *current)
 {
     struct acpi_table_header *hdr = current - sizeof(hdr->_length);
diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
index c20ace0d0b..4a8bbaf1b5 100644
--- a/include/hw/acpi/acpi.h
+++ b/include/hw/acpi/acpi.h
@@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);
 uint8_t *acpi_table_next(uint8_t *current);
 unsigned acpi_table_len(void *current);
 void acpi_table_add(const QemuOpts *opts, Error **errp);
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp);
 
 typedef struct AcpiSlicOem AcpiSlicOem;
 struct AcpiSlicOem {
-- 
2.19.1

  parent reply	other threads:[~2019-01-29  0:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25  6:01 [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-25  6:01 ` [Qemu-devel] [PATCH 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
2019-01-25  6:01 ` [Qemu-devel] [PATCH 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-01-28 13:32 ` [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Igor Mammedov
2019-01-29  0:01   ` Wei Yang
2019-01-29  0:08 ` [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-01-29  0:08   ` [Qemu-devel] [PATCH v2 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-29  8:25     ` Philippe Mathieu-Daudé
2019-01-29  0:08   ` Wei Yang [this message]
2019-01-29  8:27     ` [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Philippe Mathieu-Daudé
2019-01-29  0:08   ` [Qemu-devel] [PATCH v2 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-01-29  8:30     ` Philippe Mathieu-Daudé
2019-01-29  6:56   ` [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi Philippe Mathieu-Daudé
2019-01-29  8:04     ` Wei Yang
2019-01-29  8:23       ` Philippe Mathieu-Daudé
2019-01-29  8:43         ` Laurent Vivier
2019-01-29 15:32           ` Wei Yang
2019-01-29 15:58             ` Michael S. Tsirkin
2019-01-29 23:58               ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129000820.31190-3-richardw.yang@linux.intel.com \
    --to=richardw.yang@linux.intel.com \
    --cc=imammedo@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.