Re: [Drbd-dev] [PATCH] block: Mark expected switch fall-throughs

From: Roland Kammerer <roland.kammerer@linbit.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	Jens Axboe <axboe@kernel.dk>,
	Joshua Morris <josh.h.morris@us.ibm.com>,
	Philip Kelleher <pjk1939@linux.ibm.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] block: Mark expected switch fall-throughs
Date: Tue, 29 Jan 2019 10:42:31 +0100	[thread overview]
Message-ID: <20190129094230.ezjzpfwf5xx47luu@rck.sh> (raw)
In-Reply-To: <20190123064501.GA26147@embeddedor>

On Wed, Jan 23, 2019 at 12:45:01AM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/block/drbd/drbd_int.h      | 2 +-
>  drivers/block/drbd/drbd_receiver.c | 4 ++--
>  drivers/block/drbd/drbd_req.c      | 2 +-
>  drivers/block/rsxx/core.c          | 1 +
>  4 files changed, 5 insertions(+), 4 deletions(-)
> 

Hi Gustavo,

as also discussed with Lars in person, obviously OK for the DRBD part.

Acked-by: Roland Kammerer <roland.kammerer@linbit.com>

Best, rck