From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael Walle" <michael@walle.cc>, "Fam Zheng" <fam@euphon.net>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Brad Smith" <brad@comstyle.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/5] configure: Let SDL support be optional on OpenBSD
Date: Wed, 30 Jan 2019 08:52:52 +0100 [thread overview]
Message-ID: <20190130075252.b5l2g5flvg54uw6d@sirius.home.kraxel.org> (raw)
In-Reply-To: <20190129150029.29829-5-philmd@redhat.com>
Hi,
> sdl)
> if test "$sdl" = "no"; then
> - error_exit "sdl not found or disabled, can not use sdl audio driver"
> + echo "WARNING: SDL not found or disabled, can not use sdl audio driver"
> + audio_drv_list=$(echo "$audio_drv_list" | sed -e 's/sdl *//g')
Not needed any more.
> +if test -z "$audio_drv_list"; then
> + audio_drv_list="none"
> +fi
That puts "none" into the list of audio drivers. I don't think we
should do that. If you want prettify the output in case audio_drv_list
is empty, then just fix the output code.
cheers,
Gerd
next prev parent reply other threads:[~2019-01-30 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 15:00 [Qemu-devel] [PATCH v3 0/5] sdl: Let it be optional (in particular, on OpenBSD) Philippe Mathieu-Daudé
2019-01-29 15:00 ` [Qemu-devel] [PATCH v3 1/5] hw/lm32: Move LM32 specific hardware out of common-obj list Philippe Mathieu-Daudé
2019-01-30 7:44 ` Gerd Hoffmann
2019-01-29 15:00 ` [Qemu-devel] [PATCH v3 2/5] configure: LM32 Milkymist Texture Mapping Unit (tmu2) also depends of X11 Philippe Mathieu-Daudé
2019-01-29 15:00 ` [Qemu-devel] [PATCH v3 3/5] hw/display/milkymist-tmu2: Explicit the dependency to both X11 / OpenGL Philippe Mathieu-Daudé
2019-01-29 15:00 ` [Qemu-devel] [PATCH v3 4/5] configure: Let SDL support be optional on OpenBSD Philippe Mathieu-Daudé
2019-01-30 7:52 ` Gerd Hoffmann [this message]
2019-01-29 15:00 ` [Qemu-devel] [PATCH v3 5/5] hw/display/milkymist-tmu2: Move inlined code from header to source Philippe Mathieu-Daudé
2019-02-03 1:24 ` [Qemu-devel] [PATCH v3 0/5] sdl: Let it be optional (in particular, on OpenBSD) no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130075252.b5l2g5flvg54uw6d@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=brad@comstyle.com \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=michael@walle.cc \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.