From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>
Cc: David Sterba <dsterba@suse.cz>,
guaneryu@gmail.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org
Subject: Re: [PATCH 4/3] generic: posix acl extended attribute memory corruption test
Date: Wed, 20 Feb 2019 10:58:47 -0800 [thread overview]
Message-ID: <20190220185847.GP32253@magnolia> (raw)
In-Reply-To: <alpine.LNX.2.21.9999.1902201501470.8769@tux.applied-asynchrony.com>
On Wed, Feb 20, 2019 at 03:09:32PM +0100, Holger Hoffstätte wrote:
>
> On Wed, 20 Feb 2019, David Sterba wrote:
>
> > On Wed, Feb 13, 2019 at 12:48:14PM -0800, Darrick J. Wong wrote:
> > > +#include <attr/xattr.h>
> >
> > This does not compile on some systems, sys/xattr.h works (it's provided
> > by glibc) and is also used by other fstests' sources. I'm not sure where
> > does attr/xattr.h come from, my devel package for libattr provides only
> > attr/libattr.h.
>
> This was removed from attr back in 2015 [1] but apparently caused
> many aplications to no longer compile, so some packagers added attr/xattr.h
> back, completing the cycle of confusion.
> I just randomly remembered because Gentoo fell into the same sinkhole
> and is still climbing out [2].
>
> AFAIK sys/xattr.h is the preferred thing now unless you are building on an
> ancient distro.
...an ancient distro like Debian Testing or Ubuntu 18.04, which still
ships libattr 2.4.47, which has manpages telling you to use
attr/xattr.h.
OTOH xfsprogs has been using sys/xattr.h since 2009, so patch coming
soon.
--D
> cheers
> Holger
>
> [1] http://git.savannah.nongnu.org/cgit/attr.git/commit/?id=7921157890d07858d092f4003ca4c6bae9fd2c38
> [2] https://bugs.gentoo.org/648864
next prev parent reply other threads:[~2019-02-20 18:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 2:17 [PATCH 0/3] fstests: fixes and new tests Darrick J. Wong
2019-02-12 2:17 ` [PATCH 1/3] common: fix kmemleak to work with sections Darrick J. Wong
2019-02-12 2:17 ` [PATCH 2/3] common: fix _require_btime for lazy filesystems Darrick J. Wong
2019-02-12 2:17 ` [PATCH 3/3] generic: check for reasonable inode creation time Darrick J. Wong
2019-02-13 20:48 ` [PATCH 4/3] generic: posix acl extended attribute memory corruption test Darrick J. Wong
2019-02-16 12:05 ` Eryu Guan
2019-02-16 17:24 ` Darrick J. Wong
2019-02-20 13:29 ` David Sterba
2019-02-20 14:09 ` Holger Hoffstätte
2019-02-20 18:58 ` Darrick J. Wong [this message]
2019-02-25 18:57 ` Jeff Mahoney
2019-02-25 21:00 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220185847.GP32253@magnolia \
--to=darrick.wong@oracle.com \
--cc=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=holger@applied-asynchrony.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.