Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

From: Brian Starkey <Brian.Starkey@arm.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"james qian wang (Arm Technology China)"
	<james.qian.wang@arm.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, nd <nd@arm.com>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job
Date: Thu, 21 Feb 2019 09:34:10 +0000	[thread overview]
Message-ID: <20190221093410.b2wezvc5jkbw6wez@DESKTOP-E1NTVVP.localdomain> (raw)
In-Reply-To: <20190221081935.GA3451@pendragon.ideasonboard.com>

On Thu, Feb 21, 2019 at 10:19:35AM +0200, Laurent Pinchart wrote:
> Hi Daniel,
> 
> Thank you for the patch.
> 
> On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote:
> > No implementation, no callers.
> 
> The issue here isn't that the function is declared, but that it's not
> defined. Jobs are leaked when atomic commit fails (or when using test
> commits). I'm working on a fix, please don't apply this patch in the
> meantime.

Yeah, looking at the series somehow the call to cleanup the writeback
job on failure looks like it got lost between v9 and v10. I saw a
patch internally, but looks like James didn't send it to the list yet.

@James, could you send out your patch which fixes the cleanup on
failure?

Thanks,
-Brian

> 
> > Cc: Brian Starkey <brian.starkey@arm.com>
> > Cc: Liviu Dudau <liviu.dudau@arm.com>
> > Cc: Eric Anholt <eric@anholt.net>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  include/drm/drm_writeback.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h
> > index 23df9d463003..f34895f7fcb1 100644
> > --- a/include/drm/drm_writeback.h
> > +++ b/include/drm/drm_writeback.h
> > @@ -125,8 +125,6 @@ int drm_writeback_connector_init(struct drm_device *dev,
> >  void drm_writeback_queue_job(struct drm_writeback_connector *wb_connector,
> >  			     struct drm_writeback_job *job);
> >  
> > -void drm_writeback_cleanup_job(struct drm_writeback_job *job);
> > -
> >  void
> >  drm_writeback_signal_completion(struct drm_writeback_connector *wb_connector,
> >  				int status);
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel