From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Kamil Rytarowski" <n54@gmx.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Brad Smith" <brad@comstyle.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eric Blake" <eblake@redhat.com>
Subject: [Qemu-devel] [PATCH v4 1/4] tests/multiboot: Improve portability by searching bash in the $PATH
Date: Thu, 7 Mar 2019 15:58:36 +0100 [thread overview]
Message-ID: <20190307145839.13128-2-philmd@redhat.com> (raw)
In-Reply-To: <20190307145839.13128-1-philmd@redhat.com>
Bash is not always installed as /bin/bash. In particular on OpenBSD,
the package installs it in /usr/local/bin.
Use the 'env' shebang to search bash in the $PATH.
Reviewed-by: Kamil Rytarowski <n54@gmx.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/multiboot/run_test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/multiboot/run_test.sh b/tests/multiboot/run_test.sh
index 6c33003e71..98df91e6af 100755
--- a/tests/multiboot/run_test.sh
+++ b/tests/multiboot/run_test.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
# Copyright (c) 2013 Kevin Wolf <kwolf@redhat.com>
#
--
2.20.1
next prev parent reply other threads:[~2019-03-07 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 14:58 [Qemu-devel] [PATCH v4 0/4] tests: Allow use of Ports bash and GNU sed extensions Philippe Mathieu-Daudé
2019-03-07 14:58 ` Philippe Mathieu-Daudé [this message]
2019-03-07 14:58 ` [Qemu-devel] [PATCH v4 2/4] tests/bios-tables: Improve portability by searching bash in the $PATH Philippe Mathieu-Daudé
2019-03-07 19:50 ` Thomas Huth
2019-03-08 10:11 ` Kevin Wolf
2019-03-07 14:58 ` [Qemu-devel] [PATCH v4 3/4] qemu-iotests: " Philippe Mathieu-Daudé
2019-03-07 14:58 ` [Qemu-devel] [PATCH v4 4/4] qemu-iotests: Ensure GNU sed is used Philippe Mathieu-Daudé
2019-03-07 15:27 ` [Qemu-devel] [PATCH v4 0/4] tests: Allow use of Ports bash and GNU sed extensions Thomas Huth
2019-03-07 15:41 ` Kevin Wolf
2019-03-07 15:44 ` Philippe Mathieu-Daudé
2019-03-08 3:18 ` Michael S. Tsirkin
2019-03-07 16:24 ` Kevin Wolf
2019-03-07 16:41 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307145839.13128-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=brad@comstyle.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=n54@gmx.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.