From: Niels de Vos <ndevos@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, integration@gluster.org,
qemu-devel@nongnu.org, Stefano Garzarella <sgarzare@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] block: Gluster 6 compatibility
Date: Sat, 9 Mar 2019 10:40:00 +0100 [thread overview]
Message-ID: <20190309094000.GB3535@ndevos-x270> (raw)
In-Reply-To: <20190308131151.GA31583@localhost.localdomain>
On Fri, Mar 08, 2019 at 02:11:51PM +0100, Kevin Wolf wrote:
> Am 05.03.2019 um 16:46 hat Niels de Vos geschrieben:
> > Gluster 6 is currently available as release candidate. There have been a
> > few changes to libgfapi.so that need to be adapted by consuming projects
> > like QEMU. Fedora Rawhide already contains glusterfs-6.0-RC0, and this
> > prevents rebuilds of QEMU there (https://bugzilla.redhat.com/1684298).
> >
> > The following two changes should be sufficient to consume Gluster 6 once
> > it is released. These have been tested on CentOS-7 with Gluster 5 and
> > Gluster 6 (minimal manual qemu-img tests only).
> >
> > This v2 post contains changes suggested by Daniel P. Berrangé and Kevin
> > Wolf. Thanks!
>
> Thanks, applied to the block branch.
Thanks! Stefano Garzarella gave a suggestion for further cleanup. I was
planning to address that (no #ifdef for function arguments) next week
when I'm back from a trip, Is that something you would also like to see,
or do you prefer the change to stay minimal/small as it is now? I'm
happy to send a followup if you agree that it is cleaner.
Niels
next prev parent reply other threads:[~2019-03-09 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 15:46 [Qemu-devel] [PATCH v2 0/2] block: Gluster 6 compatibility Niels de Vos
2019-03-05 15:46 ` [Qemu-devel] [PATCH v5 1/2] block/gluster: Handle changed glfs_ftruncate signature Niels de Vos
2019-03-06 10:46 ` Stefano Garzarella
2019-03-05 15:46 ` [Qemu-devel] [PATCH v2 2/2] gluster: the glfs_io_cbk callback function pointer adds pre/post stat args Niels de Vos
2019-03-06 10:52 ` Stefano Garzarella
2019-03-08 13:11 ` [Qemu-devel] [Qemu-block] [PATCH v2 0/2] block: Gluster 6 compatibility Kevin Wolf
2019-03-09 9:40 ` Niels de Vos [this message]
2019-03-11 11:10 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309094000.GB3535@ndevos-x270 \
--to=ndevos@redhat.com \
--cc=integration@gluster.org \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.