From: Christoph Hellwig <hch@infradead.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
hch@infradead.org, Nikos Tsironis <ntsironis@arrikto.com>,
agk@redhat.com, dm-devel@redhat.com, mpatocka@redhat.com,
iliastsi@arrikto.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] list_bl: Add hlist_bl_add_before/behind helpers
Date: Mon, 11 Mar 2019 11:16:08 -0700 [thread overview]
Message-ID: <20190311181607.GA9388@infradead.org> (raw)
In-Reply-To: <20190228213201.GB23527@redhat.com>
On Thu, Feb 28, 2019 at 04:32:02PM -0500, Mike Snitzer wrote:
> Hi Paul and Christoph,
>
> You've added your Signed-off-by to include/linux/list_bl.h commits in
> the past. I'm not sure how this proposed patch should be handled.
>
> These new hlist_bl_add_{before,behind} changes are a prereq for
> dm-snapshot changes that Nikos has proposed, please see:
> https://patchwork.kernel.org/patch/10739265/
>
> Any assistance/review you, or others on LKML, might be able to provide
> would be appreciated.
I just killed two helpers. That being said assuming that we only
rely on the next pointer for the lockless traversals the changes look
fine to me, but the code might be beyond my paygrade..
next prev parent reply other threads:[~2019-03-11 18:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 18:06 [PATCH 0/3] dm snapshot: Improve performance using a more fine-grained locking scheme Nikos Tsironis
2018-12-20 18:06 ` [PATCH 1/3] list_bl: Add hlist_bl_add_before/behind helpers Nikos Tsironis
2019-02-28 21:32 ` Mike Snitzer
2019-02-28 21:34 ` Mike Snitzer
2019-03-11 18:16 ` Christoph Hellwig [this message]
2019-03-11 22:13 ` Paul E. McKenney
2019-03-11 22:43 ` Mike Snitzer
2019-03-14 0:25 ` Paul E. McKenney
2019-03-13 23:48 ` Paul E. McKenney
2019-03-14 0:30 ` Mike Snitzer
2019-03-14 13:28 ` [dm-devel] " Nikos Tsironis
2019-03-14 13:28 ` Nikos Tsironis
2019-03-14 14:07 ` [dm-devel] " Paul E. McKenney
2019-03-14 15:03 ` Paul E. McKenney
2019-03-17 11:52 ` Nikos Tsironis
2019-03-18 17:16 ` Paul E. McKenney
2019-03-20 20:25 ` Nikos Tsironis
2019-03-14 17:01 ` Nikos Tsironis
2018-12-20 18:06 ` [PATCH 2/3] dm snapshot: Don't sleep holding the snapshot lock Nikos Tsironis
2018-12-20 18:06 ` [PATCH 3/3] dm snapshot: Use fine-grained locking scheme Nikos Tsironis
2019-02-28 21:37 ` Mikulas Patocka
2019-03-01 9:15 ` Nikos Tsironis
2019-02-18 14:22 ` [PATCH 0/3] dm snapshot: Improve performance using a more " Nikos Tsironis
2019-02-18 14:37 ` Mikulas Patocka
2019-02-18 15:15 ` Mike Snitzer
2019-02-19 11:04 ` Nikos Tsironis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311181607.GA9388@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=iliastsi@arrikto.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=ntsironis@arrikto.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.