From: Roman Gushchin <guro@fb.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru
Date: Tue, 12 Mar 2019 00:22:23 +0000 [thread overview]
Message-ID: <20190312002217.GA31718@tower.DHCP.thefacebook.com> (raw)
In-Reply-To: <20190311231633.GF19508@bombadil.infradead.org>
On Mon, Mar 11, 2019 at 04:16:33PM -0700, Matthew Wilcox wrote:
> On Mon, Mar 11, 2019 at 08:49:23PM +0000, Roman Gushchin wrote:
> > The patchset looks good to me, however I'd add some clarifications
> > why switching from lru to slab_list is safe.
> >
> > My understanding is that the slab_list fields isn't currently in use,
> > but it's not that obvious that putting slab_list and next/pages/pobjects
> > fields into a union is safe (for the slub case).
>
> It's already in a union.
>
> struct page {
> union {
> struct { /* Page cache and anonymous pages */
> struct list_head lru;
> ...
> struct { /* slab, slob and slub */
> union {
> struct list_head slab_list; /* uses lru */
> struct { /* Partial pages */
> struct page *next;
>
> slab_list and lru are in the same bits. Once this patch set is in,
> we can remove the enigmatic 'uses lru' comment that I added.
Ah, perfect, thanks! Makes total sense then.
Tobin, can you, please, add a note to the commit message?
With the note:
Reviewed-by: Roman Gushchin <guro@fb.com>
Thank you!
next prev parent reply other threads:[~2019-03-12 0:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 1:07 [PATCH 0/4] mm: Use slab_list list_head instead of lru Tobin C. Harding
2019-03-11 1:07 ` [PATCH 1/4] slub: Add comments to endif pre-processor macros Tobin C. Harding
2019-03-11 1:07 ` [PATCH 2/4] slub: Use slab_list instead of lru Tobin C. Harding
2019-03-11 1:07 ` [PATCH 3/4] slab: " Tobin C. Harding
2019-03-11 1:07 ` [PATCH 4/4] slob: " Tobin C. Harding
2019-03-11 20:49 ` [PATCH 0/4] mm: Use slab_list list_head " Roman Gushchin
2019-03-11 23:16 ` Matthew Wilcox
2019-03-12 0:22 ` Roman Gushchin [this message]
2019-03-12 1:06 ` Tobin C. Harding
2019-03-12 2:01 ` Tobin C. Harding
2019-03-12 17:19 ` Roman Gushchin
2019-03-12 1:05 ` Tobin C. Harding
2019-03-12 2:38 ` Matthew Wilcox
2019-03-12 3:53 ` Tobin C. Harding
2019-03-12 17:22 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312002217.GA31718@tower.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tobin@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.