From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH 0/2] pwm: ensure pwm_apply_state() doesn't modify the state argument
Date: Tue, 12 Mar 2019 09:35:35 +0100 [thread overview]
Message-ID: <20190312083537.23748-1-u.kleine-koenig@pengutronix.de> (raw)
Hello,
this series is a followup to my mail claiming that changing the state
argument for a caller of pwm_apply_state() is a bad idea. See the commit
log for the second patch for the reasoning.
The only driver that actually modified the argument is the rockchip
driver which howver didn't ensure that struct pwm_device::state is
updated accordingly which made pwm_get_state() return the old state. The
first patch addresses this by dropping the modification.
Best regards
Uwe
Uwe Kleine-König (2):
pwm: rockchip: Don't update the state for the caller of
pwm_apply_state()
pwm: ensure pwm_apply_state() doesn't modify the state argument
drivers/pwm/core.c | 2 +-
drivers/pwm/pwm-atmel-hlcdc.c | 2 +-
drivers/pwm/pwm-atmel.c | 2 +-
drivers/pwm/pwm-bcm-iproc.c | 2 +-
drivers/pwm/pwm-cros-ec.c | 2 +-
drivers/pwm/pwm-hibvt.c | 2 +-
drivers/pwm/pwm-imx27.c | 2 +-
drivers/pwm/pwm-lpss.c | 2 +-
drivers/pwm/pwm-meson.c | 2 +-
drivers/pwm/pwm-rcar.c | 2 +-
drivers/pwm/pwm-rockchip.c | 10 ++--------
drivers/pwm/pwm-stm32-lp.c | 2 +-
drivers/pwm/pwm-sun4i.c | 10 ++--------
drivers/pwm/pwm-zx.c | 2 +-
include/linux/pwm.h | 4 ++--
15 files changed, 18 insertions(+), 30 deletions(-)
--
2.20.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next reply other threads:[~2019-03-12 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 8:35 Uwe Kleine-König [this message]
[not found] ` <20190312083537.23748-1-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2019-03-12 8:35 ` [PATCH 1/2] pwm: rockchip: Don't update the state for the caller of pwm_apply_state() Uwe Kleine-König
2019-03-12 8:35 ` [PATCH 2/2] pwm: ensure pwm_apply_state() doesn't modify the state argument Uwe Kleine-König
[not found] ` <20190312083537.23748-3-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2019-03-12 11:42 ` Thierry Reding
2019-03-12 12:59 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312083537.23748-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.