From: kbuild test robot <lkp@intel.com>
To: David Sterba <dsterba@suse.com>
Cc: kbuild-all@01.org, linux-btrfs@vger.kernel.org,
David Sterba <dsterba@suse.com>
Subject: Re: [PATCH 4/9] btrfs: use assertion helpers for spinning readers
Date: Sat, 16 Mar 2019 00:18:30 +0800 [thread overview]
Message-ID: <201903160031.tA3xYCpn%lkp@intel.com> (raw)
In-Reply-To: <a76a27b87096042c0ad2d5ab2e05b586dd2f0e58.1552489554.git.dsterba@suse.com>
[-- Attachment #1: Type: text/plain, Size: 2731 bytes --]
Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on kdave/for-next]
[also build test ERROR on next-20190306]
[cannot apply to v5.0]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/David-Sterba/Extent-buffer-locking-cleanups/20190315-231346
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: i386-randconfig-x011-201910 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
fs/btrfs/locking.c: In function 'btrfs_clear_lock_blocking_read':
>> fs/btrfs/locking.c:97:18: error: 'struct extent_buffer' has no member named 'spinning_readers'; did you mean 'blocking_readers'?
atomic_inc(&eb->spinning_readers);
^~~~~~~~~~~~~~~~
blocking_readers
vim +97 fs/btrfs/locking.c
b4ce94de Chris Mason 2009-02-04 85
aa12c027 David Sterba 2018-04-04 86 void btrfs_clear_lock_blocking_read(struct extent_buffer *eb)
aa12c027 David Sterba 2018-04-04 87 {
b4ce94de Chris Mason 2009-02-04 88 /*
aa12c027 David Sterba 2018-04-04 89 * No lock is required. The lock owner may change if we have a read
aa12c027 David Sterba 2018-04-04 90 * lock, but it won't change to or away from us. If we have the write
aa12c027 David Sterba 2018-04-04 91 * lock, we are the owner and it'll never change.
b4ce94de Chris Mason 2009-02-04 92 */
aa12c027 David Sterba 2018-04-04 93 if (eb->lock_nested && current->pid == eb->lock_owner)
aa12c027 David Sterba 2018-04-04 94 return;
aa12c027 David Sterba 2018-04-04 95 BUG_ON(atomic_read(&eb->blocking_readers) == 0);
aa12c027 David Sterba 2018-04-04 96 read_lock(&eb->lock);
aa12c027 David Sterba 2018-04-04 @97 atomic_inc(&eb->spinning_readers);
aa12c027 David Sterba 2018-04-04 98 /* atomic_dec_and_test implies a barrier */
aa12c027 David Sterba 2018-04-04 99 if (atomic_dec_and_test(&eb->blocking_readers))
aa12c027 David Sterba 2018-04-04 100 cond_wake_up_nomb(&eb->read_lock_wq);
aa12c027 David Sterba 2018-04-04 101 }
aa12c027 David Sterba 2018-04-04 102
:::::: The code at line 97 was first introduced by commit
:::::: aa12c02778a9719283fc3c32cfe5cffb902a7685 btrfs: split btrfs_clear_lock_blocking_rw to read and write helpers
:::::: TO: David Sterba <dsterba@suse.com>
:::::: CC: David Sterba <dsterba@suse.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34008 bytes --]
next prev parent reply other threads:[~2019-03-15 16:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 15:46 [PATCH 0/9] Extent buffer locking cleanups David Sterba
2019-03-13 15:47 ` [PATCH 1/9] btrfs: add assertion helpers for spinning writers David Sterba
2019-03-13 15:47 ` [PATCH 2/9] btrfs: use " David Sterba
2019-03-13 15:47 ` [PATCH 3/9] btrfs: add assertion helpers for spinning readers David Sterba
2019-03-13 15:47 ` [PATCH 4/9] btrfs: use " David Sterba
2019-03-15 16:18 ` kbuild test robot [this message]
2019-03-15 21:43 ` David Sterba
2019-03-15 17:13 ` kbuild test robot
2019-03-13 15:47 ` [PATCH 5/9] btrfs: add assertion helpers for extent buffer read lock counters David Sterba
2019-03-13 15:47 ` [PATCH 6/9] btrfs: use " David Sterba
2019-03-13 15:47 ` [PATCH 7/9] btrfs: add assertion helpers for extent buffer write " David Sterba
2019-03-13 15:47 ` [PATCH 8/9] btrfs: use " David Sterba
2019-03-13 15:47 ` [PATCH 9/9] btrfs: switch extent_buffer::lock_nested to bool David Sterba
2019-03-14 7:26 ` [PATCH 0/9] Extent buffer locking cleanups Nikolay Borisov
2019-03-18 19:29 ` David Sterba
2019-03-18 19:43 ` Nikolay Borisov
2019-03-14 13:15 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201903160031.tA3xYCpn%lkp@intel.com \
--to=lkp@intel.com \
--cc=dsterba@suse.com \
--cc=kbuild-all@01.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.