From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 09/28] ARM: dts: sunxi: Fix the TCON output clock
Date: Mon, 25 Mar 2019 20:48:55 +0100 [thread overview]
Message-ID: <20190325194855.ly4g5nttfvnxo6tu@flea> (raw)
In-Reply-To: <CAGb2v65fQVOsxh6PwwTmnQFqbdgbttNGoF_xe06Rm2bhuM4SjQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1746 bytes --]
On Tue, Mar 26, 2019 at 12:58:25AM +0800, Chen-Yu Tsai wrote:
> On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > Even though we shouldn't really have any external user of the clock
> > provided by the TCON, if clock-output-names is set, then #clock-cells must
> > be there as well.
> >
> > Fix this.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> > arch/arm/boot/dts/sun4i-a10.dtsi | 2 ++
> > arch/arm/boot/dts/sun5i.dtsi | 1 +
> > arch/arm/boot/dts/sun6i-a31.dtsi | 2 ++
> > arch/arm/boot/dts/sun7i-a20.dtsi | 2 ++
> > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 1 +
> > arch/arm/boot/dts/sun8i-a83t.dtsi | 1 +
> > arch/arm/boot/dts/sun8i-v3s.dtsi | 1 +
> > arch/arm/boot/dts/sun9i-a80.dtsi | 1 +
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 1 +
> > 9 files changed, 12 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> > index 73c3ac42095f..93bc260a80af 100644
> > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > @@ -343,6 +343,7 @@
> > "tcon-ch1";
> > clock-output-names = "tcon0-pixel-clock";
> > dmas = <&dma SUN4I_DMA_DEDICATED 14>;
> > + #clock-cells = <0>;
>
> Nit: could we group #clock-cells with clock-output-names?
>
> Either way,
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
I fixed it (and split the A64 change in a separate patch) while
applying, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-25 19:49 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 13:52 [PATCH 01/28] dt-bindings: arm: Remove the CPU compatible documentation Maxime Ripard
2019-03-25 13:52 ` [PATCH 02/28] ARM: dts: sun9i: optimus: Fix fixed-regulators Maxime Ripard
2019-03-25 16:49 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 03/28] ARM: dts: sunxi: Remove stale pinctrl-names entry Maxime Ripard
2019-03-25 16:50 ` Chen-Yu Tsai
2019-03-25 20:02 ` Maxime Ripard
2019-03-25 13:52 ` [PATCH 04/28] ARM: dts: sun5i: lichee-pi one: " Maxime Ripard
2019-03-25 16:50 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 05/28] ARM: dts: sunxi: Fix GIC compatible Maxime Ripard
2019-03-25 16:50 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 06/28] ARM: dts: sunxi: Switch to new GPIOs properties for i2c-gpio Maxime Ripard
2019-03-25 16:55 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 07/28] ARM: sunxi: Fix the USB PHY ID detect GPIO properties Maxime Ripard
2019-03-25 16:55 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 08/28] ARM: sunxi: Fix the USB PHY VBUS " Maxime Ripard
2019-03-25 16:56 ` Chen-Yu Tsai
2019-03-25 19:41 ` Maxime Ripard
2019-03-25 13:52 ` [PATCH 09/28] ARM: dts: sunxi: Fix the TCON output clock Maxime Ripard
2019-03-25 16:58 ` Chen-Yu Tsai
2019-03-25 19:48 ` Maxime Ripard [this message]
2019-03-25 13:52 ` [PATCH 10/28] ARM: dts: sun8i: tbs-a711: Fix typo in regulators Maxime Ripard
2019-03-25 16:59 ` Chen-Yu Tsai
2019-03-25 19:50 ` Maxime Ripard
2019-03-25 13:52 ` [PATCH 11/28] ARM: sunxi: dts: Split USB PHY cells into an array Maxime Ripard
2019-03-25 16:59 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 12/28] ARM: dts: sun8i: r40: Fix AHCI reset-names property Maxime Ripard
2019-03-25 17:00 ` Chen-Yu Tsai
2019-03-25 19:52 ` Maxime Ripard
2019-03-25 13:52 ` [PATCH 13/28] ARM: dts: sun8i: r40: Remove useless AHCI properties Maxime Ripard
2019-03-25 17:00 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 14/28] arm64: dts: allwinner: a64: Fix endpoints nodes Maxime Ripard
2019-03-25 17:02 ` Chen-Yu Tsai
2019-03-25 19:57 ` Maxime Ripard
2019-03-25 13:52 ` [PATCH 15/28] ARM: dts: sunxi: Remove pinctrl size-cells property Maxime Ripard
2019-03-25 17:02 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 16/28] ARM: dts: sun8i: A23/A33: Fix pinctrl node names Maxime Ripard
2019-03-25 17:02 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 17/28] ARM: dts: sun9i: Remove deprecated pinctrl properties Maxime Ripard
2019-03-26 3:03 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 18/28] arm64: dts: allwinner: a64: Add missing PIO clocks Maxime Ripard
2019-03-25 17:04 ` Chen-Yu Tsai
2019-03-25 19:58 ` Maxime Ripard
2019-03-25 13:52 ` [PATCH 19/28] arm64: dts: allwinner: Fix pinctrl node names Maxime Ripard
2019-03-25 17:04 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 20/28] ARM: dts: sun8i: h3: Refactor the " Maxime Ripard
2019-03-25 17:06 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 21/28] ARM: dts: sunxi: Add default dr_mode Maxime Ripard
2019-03-25 17:07 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 22/28] ARM: dts: sun8i: h3: " Maxime Ripard
2019-03-26 2:46 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 23/28] arm64: dts: allwinner: a64: " Maxime Ripard
2019-03-26 2:47 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 24/28] ARM: dts: sun8i: a83t: Fix the SPDIF binding Maxime Ripard
2019-03-26 2:48 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 25/28] ARM: dts: sun8i: h3: " Maxime Ripard
2019-03-26 2:53 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 26/28] arm64: dts: allwinner: a64: " Maxime Ripard
2019-03-26 2:54 ` Chen-Yu Tsai
2019-03-26 2:55 ` Chen-Yu Tsai
2019-03-25 13:52 ` [PATCH 27/28] arm64: dts: allwinner: a64: Fix the Codec I2S binding Maxime Ripard
2019-03-26 2:55 ` Chen-Yu Tsai
2019-03-25 13:53 ` [PATCH 28/28] ARM: dts: sun8i: a83t: Fix the " Maxime Ripard
2019-03-26 2:58 ` Chen-Yu Tsai
2019-03-25 16:48 ` [PATCH 01/28] dt-bindings: arm: Remove the CPU compatible documentation Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325194855.ly4g5nttfvnxo6tu@flea \
--to=maxime.ripard@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.