From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Christoph Hellwig <hch@infradead.org>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
James Smart <james.smart@broadcom.com>,
Dongli Zhang <dongli.zhang@oracle.com>,
Laurence Oberman <loberman@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] block: Revert v5.0 blk_mq_request_issue_directly() changes
Date: Fri, 5 Apr 2019 05:43:45 +0800 [thread overview]
Message-ID: <20190404214344.GA30656@ming.t460p> (raw)
In-Reply-To: <20190404170843.83517-1-bvanassche@acm.org>
On Thu, Apr 04, 2019 at 10:08:43AM -0700, Bart Van Assche wrote:
> blk_mq_try_issue_directly() can return BLK_STS*_RESOURCE for requests that
> have been queued. If that happens when blk_mq_try_issue_directly() is called
> by the dm-mpath driver then dm-mpath will try to resubmit a request that is
> already queued and a kernel crash follows. Since it is nontrivial to fix
> blk_mq_request_issue_directly(), revert the blk_mq_request_issue_directly()
> changes that went into kernel v5.0.
>
> This patch reverts the following commits:
> * d6a51a97c0b2 ("blk-mq: replace and kill blk_mq_request_issue_directly") # v5.0.
> * 5b7a6f128aad ("blk-mq: issue directly with bypass 'false' in blk_mq_sched_insert_requests") # v5.0.
> * 7f556a44e61d ("blk-mq: refactor the code of issue request directly") # v5.0.
I am fine to revert them now.
However, could you revert them one by one so that they can be reviewed
easily?
Thanks,
Ming
next prev parent reply other threads:[~2019-04-04 21:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 17:08 [PATCH] block: Revert v5.0 blk_mq_request_issue_directly() changes Bart Van Assche
2019-04-04 21:43 ` Ming Lei [this message]
2019-04-04 22:02 ` Bart Van Assche
2019-04-04 23:49 ` Laurence Oberman
2019-04-05 6:06 ` Christoph Hellwig
2019-04-05 12:43 ` Laurence Oberman
2019-04-05 13:58 ` Bart Van Assche
2019-04-05 14:00 ` Bart Van Assche
2019-04-05 17:59 ` Jens Axboe
2019-04-09 5:13 ` Stewart Smith
2019-04-09 5:59 ` jianchao.wang
2019-04-17 8:02 ` Stewart Smith
2019-04-09 13:51 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404214344.GA30656@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dongli.zhang@oracle.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jianchao.w.wang@oracle.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.