From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com,
jmattson@google.com
Subject: Re: [PATCH 5/6 v4][KVM nVMX]: nested_vmx_check_vmentry_postreqs() should return VMX_EXIT_REASONS_FAILED_VMENTRY | EXIT_REASON_INVALID_STATE for error conditions
Date: Mon, 8 Apr 2019 10:27:13 -0700 [thread overview]
Message-ID: <20190408172713.GH25880@linux.intel.com> (raw)
In-Reply-To: <20190405014650.16880-6-krish.sadhukhan@oracle.com>
On Thu, Apr 04, 2019 at 09:46:49PM -0400, Krish Sadhukhan wrote:
> ..to reflect the architectural Exit Reason for VM-entry failures due to
> invalid guest state.
>
> Signed-off-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
> Suggested-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> arch/x86/kvm/vmx/nested.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index efd226d4ea36..456bf6514bb3 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -2705,7 +2705,9 @@ static int nested_vmx_check_vmentry_postreqs(struct kvm_vcpu *vcpu,
>
You missed the newly added call to nested_check_guest_cregs_dregs_msrs().
Assuming you spin v5, please fix the indentation issue in patch 1/6 as well.
> if (nested_vmx_check_vmcs_link_ptr(vcpu, vmcs12)) {
> *exit_qual = ENTRY_FAIL_VMCS_LINK_PTR;
> - return 1;
> +
> + return VMX_EXIT_REASONS_FAILED_VMENTRY |
> + EXIT_REASON_INVALID_STATE;
> }
>
> /*
> @@ -2724,13 +2726,17 @@ static int nested_vmx_check_vmentry_postreqs(struct kvm_vcpu *vcpu,
> ia32e != !!(vmcs12->guest_ia32_efer & EFER_LMA) ||
> ((vmcs12->guest_cr0 & X86_CR0_PG) &&
> ia32e != !!(vmcs12->guest_ia32_efer & EFER_LME)))
> - return 1;
> +
> + return VMX_EXIT_REASONS_FAILED_VMENTRY |
> + EXIT_REASON_INVALID_STATE;
> }
>
> if ((vmcs12->vm_entry_controls & VM_ENTRY_LOAD_BNDCFGS) &&
> (is_noncanonical_address(vmcs12->guest_bndcfgs & PAGE_MASK, vcpu) ||
> (vmcs12->guest_bndcfgs & MSR_IA32_BNDCFGS_RSVD)))
> - return 1;
> +
> + return VMX_EXIT_REASONS_FAILED_VMENTRY |
> + EXIT_REASON_INVALID_STATE;
>
> return 0;
> }
> --
> 2.17.2
>
next prev parent reply other threads:[~2019-04-08 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 1:46 [KVM nVMX]: Check "load IA32_PAT" VM-exit{entry} controls on vmentry of L2 guests (v4) Krish Sadhukhan
2019-04-05 1:46 ` [PATCH 1/6 v4][KVM nVMX]: Check "load IA32_PAT" VM-exit control on vmentry Krish Sadhukhan
2019-04-08 17:21 ` Sean Christopherson
2019-04-05 1:46 ` [PATCH 2/6 v4][KVM nVMX]: Check "load IA32_PAT" VM-entry " Krish Sadhukhan
2019-04-05 1:46 ` [PATCH 3/6 v4][KVM nVMX]: Move the checks for Guest Control Registers and Guest MSRs to a separate function Krish Sadhukhan
2019-04-05 1:46 ` [PATCH 4/6 v4][KVM nVMX]: nested_check_guest_cregs_dregs_msrs() should return -EINVAL for error conditions Krish Sadhukhan
2019-04-08 17:24 ` Sean Christopherson
2019-04-05 1:46 ` [PATCH 5/6 v4][KVM nVMX]: nested_vmx_check_vmentry_postreqs() should return VMX_EXIT_REASONS_FAILED_VMENTRY | EXIT_REASON_INVALID_STATE " Krish Sadhukhan
2019-04-08 17:27 ` Sean Christopherson [this message]
2019-04-05 1:46 ` [PATCH 6/6 v4][kvm-unit-test nVMX]: Check "load IA32_PAT" on vmentry of L2 guests Krish Sadhukhan
2019-04-08 17:34 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408172713.GH25880@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.