From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.de>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3.1 1/9] btrfs: delayed-ref: Introduce better documented delayed ref structures
Date: Mon, 15 Apr 2019 18:50:48 +0200 [thread overview]
Message-ID: <20190415165048.GC22216@twin.jikos.cz> (raw)
In-Reply-To: <259b0c00-cee0-32ae-aa27-4b981d64b8cb@suse.de>
On Sat, Apr 13, 2019 at 07:48:51AM +0800, Qu Wenruo wrote:
>
>
> On 2019/4/12 下午11:46, David Sterba wrote:
> > On Thu, Apr 04, 2019 at 02:45:29PM +0800, Qu Wenruo wrote:
> >> +struct btrfs_ref {
> >> + enum btrfs_ref_type type;
> >> + int action;
> >> +
> >> + /*
> >> + * Only use parent pointers as backref (SHARED_BLOCK_REF or
> >> + * SHARED_DATA_REF) for this extent and its children.
> >> + * Set for reloc trees.
> >> + */
> >> + bool only_backreferences:1;
> >
> > I renamed this to only_backrefs and was surprised that there were no
> > compilation errors, ie. this member is not used at all ...
>
> Yep, for callers who really uses this member, they just set @parent, and
> that's all.
So there's nothing in the old and new code that uses it, then why do you
add it? If this is for some existing patchset then ok, keep it there but
otherwise remove it.
next prev parent reply other threads:[~2019-04-15 16:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 6:45 [PATCH v3.1 0/9] btrfs: Refactor delayed ref parameter list Qu Wenruo
2019-04-04 6:45 ` [PATCH v3.1 1/9] btrfs: delayed-ref: Introduce better documented delayed ref structures Qu Wenruo
2019-04-05 12:09 ` David Sterba
2019-04-05 13:18 ` Qu Wenruo
2019-04-05 15:51 ` David Sterba
2019-04-05 23:47 ` Qu Wenruo
2019-04-06 6:21 ` Nikolay Borisov
2019-04-12 15:46 ` David Sterba
2019-04-12 23:48 ` Qu Wenruo
2019-04-15 16:50 ` David Sterba [this message]
2019-04-16 0:01 ` Qu Wenruo
2019-04-17 13:35 ` David Sterba
2019-04-04 6:45 ` [PATCH v3.1 2/9] btrfs: extent-tree: Open-code process_func in __btrfs_mod_ref Qu Wenruo
2019-04-04 6:45 ` [PATCH v3.1 3/9] btrfs: delayed-ref: Use btrfs_ref to refactor btrfs_add_delayed_tree_ref() Qu Wenruo
2019-04-04 6:45 ` [PATCH v3.1 4/9] btrfs: delayed-ref: Use btrfs_ref to refactor btrfs_add_delayed_data_ref() Qu Wenruo
2019-04-04 6:45 ` [PATCH v3.1 5/9] btrfs: ref-verify: Use btrfs_ref to refactor btrfs_ref_tree_mod() Qu Wenruo
2019-04-04 6:45 ` [PATCH v3.1 6/9] btrfs: extent-tree: Use btrfs_ref to refactor add_pinned_bytes() Qu Wenruo
2019-04-04 6:45 ` [PATCH v3.1 7/9] btrfs: extent-tree: Use btrfs_ref to refactor btrfs_inc_extent_ref() Qu Wenruo
2019-04-04 6:45 ` [PATCH v3.1 8/9] btrfs: extent-tree: Use btrfs_ref to refactor btrfs_free_extent() Qu Wenruo
2019-04-04 6:45 ` [PATCH v3.1 9/9] btrfs: qgroup: Don't scan leaf if we're modifying reloc tree Qu Wenruo
2019-04-05 12:06 ` [PATCH v3.1 0/9] btrfs: Refactor delayed ref parameter list David Sterba
2019-04-23 11:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415165048.GC22216@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
--cc=wqu@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.