From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v3 3/5] media: vsp1: Document partition algorithm in code header
Date: Thu, 18 Apr 2019 09:33:41 +0300 [thread overview]
Message-ID: <20190418063341.GG4806@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190411161256.19607-4-kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Thu, Apr 11, 2019 at 05:12:54PM +0100, Kieran Bingham wrote:
> The image partition algorithm operates on the image dimensions as input
> into the WPF entity. Document this in the code block header.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/platform/vsp1/vsp1_video.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
> index 563f9a02c373..d1ecc3d91290 100644
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> @@ -173,6 +173,14 @@ static int __vsp1_video_try_format(struct vsp1_video *video,
>
> /* -----------------------------------------------------------------------------
> * VSP1 Partition Algorithm support
> + *
> + * VSP hardware can have restrictions on image width dependent on the hardware
Did you mean s/dependent/depending/ ?
> + * configuration of the pipeline. Adapting for these restrictions is implemented
> + * via the partition algorithm.
> + *
> + * The partition windows and sizes are based on the output size of the WPF
> + * before rotation, which is represented by the input parameters to the WPF
> + * entity in our pipeline.
> */
>
> /**
> --
> 2.19.1
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-04-18 6:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 16:12 [PATCH v3 0/5] media: vsp1: Phased partition overlap support Kieran Bingham
2019-04-11 16:12 ` [PATCH v3 1/5] media: vsp1: Define partition algorithm helper Kieran Bingham
2019-04-18 6:30 ` Laurent Pinchart
2019-04-11 16:12 ` [PATCH v3 2/5] media: vsp1: Initialise partition windows Kieran Bingham
2019-04-18 6:32 ` Laurent Pinchart
2019-05-07 10:20 ` Kieran Bingham
2019-04-11 16:12 ` [PATCH v3 3/5] media: vsp1: Document partition algorithm in code header Kieran Bingham
2019-04-18 6:33 ` Laurent Pinchart [this message]
2019-05-07 10:22 ` Kieran Bingham
2019-04-11 16:12 ` [PATCH v3 4/5] media: vsp1: Split out pre-filter multiplier Kieran Bingham
2019-04-18 6:37 ` Laurent Pinchart
2019-05-10 11:15 ` Kieran Bingham
2019-04-11 16:12 ` [PATCH v3 5/5] media: vsp1: Provide partition overlap algorithm Kieran Bingham
2019-04-18 12:42 ` Laurent Pinchart
2019-05-13 15:32 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418063341.GG4806@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.