Re: [PATCH] crypto: caam/jr - update gcm detection logic

From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Aymen Sghaier <aymen.sghaier@nxp.com>,
	linux-crypto@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] crypto: caam/jr - update gcm detection logic
Date: Thu, 25 Apr 2019 15:50:25 +0800	[thread overview]
Message-ID: <20190425075025.bqxxlsgepb7th2up@gondor.apana.org.au> (raw)
In-Reply-To: <20190416162712.31106-1-horia.geanta@nxp.com>

On Tue, Apr 16, 2019 at 07:27:12PM +0300, Horia Geantă wrote:
> GCM detection logic has to change for two reasons:
> -some CAAM instantiations with Era < 10, even though they have AES LP,
> they now support GCM mode
> -Era 10 upwards, there is a dedicated bit in AESA_VERSION[AESA_MISC]
> field for GCM support
> 
> For Era 9 and earlier, all AES accelerator versions support GCM,
> except for AES LP (CHAVID_LS[AESVID]=3) with revision CRNR[AESRN] < 8.
> 
> For Era 10 and later, bit 9 of the AESA_VERSION register should be used
> to detect GCM support in AES accelerator.
> 
> Note: caam/qi and caam/qi2 are drivers for QI (Queue Interface), which
> is used in DPAA-based SoCs; for now, we rely on CAAM having an AES HP
> and this AES accelerator having support for GCM.
> 
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> ---
>  drivers/crypto/caam/caamalg.c | 18 +++++++++++-------
>  drivers/crypto/caam/regs.h    |  3 +++
>  2 files changed, 14 insertions(+), 7 deletions(-)

Patch applied.  Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt