From: Rob Herring <robh@kernel.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Harish Bandi <c-hbandi@codeaurora.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
mka@chromium.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org,
anubhavg@codeaurora.org, devicetree@vger.kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH v7 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998
Date: Thu, 25 Apr 2019 13:47:40 -0500 [thread overview]
Message-ID: <20190425184740.GA23300@bogus> (raw)
In-Reply-To: <B3F78119-055C-41EB-BE3B-C5C94825B93E@holtmann.org>
On Thu, Apr 25, 2019 at 02:43:56PM +0200, Marcel Holtmann wrote:
> Hi Harish,
>
> > Add compatible string for the Qualcomm WCN3998 Bluetooth controller
> >
> > Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org>
> > ---
> > Changes in V6:
> > - Changed Commit text
> > ---
> > Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> > index 824c0e2..7ef6118 100644
> > --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> > +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> > @@ -11,20 +11,21 @@ Required properties:
> > - compatible: should contain one of the following:
> > * "qcom,qca6174-bt"
> > * "qcom,wcn3990-bt"
> > + * "qcom,wcn3998-bt"
> >
> > Optional properties for compatible string qcom,qca6174-bt:
> >
> > - enable-gpios: gpio specifier used to enable chip
> > - clocks: clock provided to the controller (SUSCLK_32KHZ)
> >
> > -Required properties for compatible string qcom,wcn3990-bt:
> > +Required properties for compatible string qcom,wcn399x-bt:
> >
> > - vddio-supply: VDD_IO supply regulator handle.
> > - vddxo-supply: VDD_XO supply regulator handle.
> > - vddrf-supply: VDD_RF supply regulator handle.
> > - vddch0-supply: VDD_CH0 supply regulator handle.
> >
> > -Optional properties for compatible string qcom,wcn3990-bt:
> > +Optional properties for compatible string qcom,wcn399x-bt:
>
> wasn’t the conclusion to _not_ use x things in compatible strings? I would personally prefer you list these two compatible strings separately. However I let Rob comment and Ack this if this is fine for him.
It's fine for me as it isn't the actual string used.
Reviewed-by: Rob Herring <robh@kernel.org>
Rob
prev parent reply other threads:[~2019-04-25 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 12:13 [PATCH v7 0/2] Enable Bluetooth functionality for WCN3998 Harish Bandi
2019-04-25 12:13 ` [PATCH v7 1/2] Bluetooth: hci_qca: Added support " Harish Bandi
2019-04-25 12:47 ` Marcel Holtmann
2019-04-25 13:40 ` Harish Bandi
2019-04-25 16:46 ` Matthias Kaehlcke
2019-04-25 12:13 ` [PATCH v7 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3998 Harish Bandi
2019-04-25 12:43 ` Marcel Holtmann
2019-04-25 18:47 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425184740.GA23300@bogus \
--to=robh@kernel.org \
--cc=anubhavg@codeaurora.org \
--cc=bgodavar@codeaurora.org \
--cc=c-hbandi@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.