From: Catalin Marinas <catalin.marinas@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: mark.rutland@arm.com, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] arm64/mm: Fix pgtable page offset address in [pud|pmd]_free_[pmd|pte]_page
Date: Tue, 30 Apr 2019 17:17:59 +0100 [thread overview]
Message-ID: <20190430161759.GI29799@arrakis.emea.arm.com> (raw)
In-Reply-To: <1556595839-9282-1-git-send-email-anshuman.khandual@arm.com>
On Tue, Apr 30, 2019 at 09:13:59AM +0530, Anshuman Khandual wrote:
> @@ -1026,8 +1028,10 @@ int pud_free_pmd_page(pud_t *pudp, unsigned long addr)
> return 1;
> }
>
> - table = pmd_offset(pudp, addr);
> - pmdp = table;
> + VM_WARN_ONCE(!IS_ALIGNED(addr, PUD_SIZE),
> + "%s: unaligned address 0x%016llx\n", __func__, addr);
> + table = pmd_offset(pudp, 0UL);
> + pmdp = pmd_offset(pudp, addr);
Why does pmdp need to use addr? We are freeing the whole pmd page, so I
don't think pmdp should be different from table here.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-30 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 3:43 [PATCH V2] arm64/mm: Fix pgtable page offset address in [pud|pmd]_free_[pmd|pte]_page Anshuman Khandual
2019-04-30 16:17 ` Catalin Marinas [this message]
2019-05-01 4:45 ` Anshuman Khandual
2019-05-01 11:14 ` Catalin Marinas
2019-05-02 3:29 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430161759.GI29799@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.