From: Keith Busch <kbusch@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Alex G <mr.nuke.me@gmail.com>, Lukas Wunner <lukas@wunner.de>,
Alex Williamson <alex.williamson@redhat.com>,
Austin Bolen <austin_bolen@dell.com>,
Alexandru Gagniuc <alex_gagniuc@dellteam.com>,
Keith Busch <keith.busch@intel.com>,
Shyam Iyer <Shyam_Iyer@dell.com>, Sinan Kaya <okaya@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "PCI/LINK: Report degraded links via link bandwidth notification"
Date: Wed, 1 May 2019 07:16:15 -0600 [thread overview]
Message-ID: <20190501131614.GA26831@localhost.localdomain> (raw)
In-Reply-To: <20190501021249.GD145057@google.com>
On Tue, Apr 30, 2019 at 09:12:49PM -0500, Bjorn Helgaas wrote:
> On Tue, Apr 30, 2019 at 12:18:13PM -0600, Keith Busch wrote:
> > On Tue, Apr 30, 2019 at 12:05:09PM -0600, Keith Busch wrote:
> > > On Tue, Apr 30, 2019 at 11:11:51AM -0500, Bjorn Helgaas wrote:
> > > > > I'm not convinced a revert is the best call.
> > > >
> > > > I have very limited options at this stage of the release, but I'd be
> > > > glad to hear suggestions. My concern is that if we release v5.1
> > > > as-is, we'll spend a lot of energy on those false positives.
> > >
> > > May be too late now if the revert is queued up, but I think this feature
> > > should have been a default 'false' Kconfig bool rather than always on.
>
> Since this feature currently just adds a message in dmesg, which we
> don't really consider a stable API, I think a Kconfig switch is a
> reasonable option.
>
> If you send me a signed-off-by for the following patch, I can apply it:
Sounds good, I'll need to resend though since I messed up the Makefile:
> +obj-$(CONFIG_PCIE_BW) := bw_notification.o
s/:=/+=
next prev parent reply other threads:[~2019-05-01 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 18:56 [PATCH] Revert "PCI/LINK: Report degraded links via link bandwidth Bjorn Helgaas
2019-04-29 18:56 ` [PATCH] Revert "PCI/LINK: Report degraded links via link bandwidth notification" Bjorn Helgaas
2019-04-29 19:21 ` Alex Williamson
2019-04-30 1:07 ` Alex G
2019-04-30 16:11 ` Bjorn Helgaas
2019-04-30 18:05 ` Keith Busch
2019-04-30 18:18 ` Keith Busch
2019-05-01 2:12 ` Bjorn Helgaas
2019-05-01 13:16 ` Keith Busch [this message]
2019-04-30 23:09 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501131614.GA26831@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=Shyam_Iyer@dell.com \
--cc=alex.williamson@redhat.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.