From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jens Axboe <axboe@kernel.dk>,
Steven Whitehouse <swhiteho@redhat.com>,
Bob Peterson <rpeterso@redhat.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Abhi Das <adas@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>
Subject: linux-next: build failure after merge of the block tree
Date: Mon, 6 May 2019 15:07:07 +1000 [thread overview]
Message-ID: <20190506150707.618f013d@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 2039 bytes --]
Hi Jens,
After merging the block tree, today's linux-next build (x86_64
allmodconfig) failed like this:
fs/gfs2/lops.c: In function 'gfs2_end_log_read':
fs/gfs2/lops.c:394:49: error: macro "bio_for_each_segment_all" passed 4 arguments, but takes just 3
bio_for_each_segment_all(bvec, bio, i, iter_all) {
^
fs/gfs2/lops.c:394:2: error: 'bio_for_each_segment_all' undeclared (first use in this function); did you mean 'bio_first_page_all'?
bio_for_each_segment_all(bvec, bio, i, iter_all) {
^~~~~~~~~~~~~~~~~~~~~~~~
bio_first_page_all
fs/gfs2/lops.c:394:2: note: each undeclared identifier is reported only once for each function it appears in
fs/gfs2/lops.c:394:26: error: expected ';' before '{' token
bio_for_each_segment_all(bvec, bio, i, iter_all) {
^ ~
;
Caused by commit
2b070cfe582b ("block: remove the i argument to bio_for_each_segment_all")
interacting with commit
e21e191994af ("gfs2: read journal in large chunks")
from the gfs2 tree.
I have applied the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 6 May 2019 14:57:42 +1000
Subject: [PATCH] gfs2: fix for "block: remove the i argument to bio_for_each_segment_all"
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
fs/gfs2/lops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index 3b3dd2ef53f7..33ab662c9aac 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -388,10 +388,9 @@ static void gfs2_end_log_read(struct bio *bio)
{
struct page *page;
struct bio_vec *bvec;
- int i;
struct bvec_iter_all iter_all;
- bio_for_each_segment_all(bvec, bio, i, iter_all) {
+ bio_for_each_segment_all(bvec, bio, iter_all) {
page = bvec->bv_page;
if (bio->bi_status) {
int err = blk_status_to_errno(bio->bi_status);
--
2.20.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2019-05-06 5:07 UTC|newest]
Thread overview: 279+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 5:07 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-10 3:10 linux-next: build failure after merge of the block tree Stephen Rothwell
2024-05-10 7:22 ` Damien Le Moal
2024-05-13 23:53 ` Stephen Rothwell
2023-12-21 3:01 Stephen Rothwell
2023-12-21 3:11 ` Jens Axboe
2023-12-21 5:25 ` Christoph Hellwig
2023-06-01 0:50 Stephen Rothwell
2023-06-01 8:27 ` Johannes Thumshirn
2023-06-01 15:14 ` Jens Axboe
2023-03-24 1:57 Stephen Rothwell
2023-03-22 23:33 Stephen Rothwell
2023-03-22 23:59 ` Stephen Rothwell
2023-01-19 23:07 Stephen Rothwell
2023-01-06 0:19 Stephen Rothwell
2023-01-06 2:53 ` Martin K. Petersen
2022-11-16 1:35 Stephen Rothwell
2022-10-04 21:50 Stephen Rothwell
2022-10-04 22:14 ` Jens Axboe
2022-08-22 4:46 Stephen Rothwell
2022-08-22 13:55 ` Jens Axboe
2022-08-22 15:34 ` Bart Van Assche
2022-08-22 15:40 ` Jens Axboe
2022-08-22 16:06 ` Bart Van Assche
2022-08-22 16:07 ` Jens Axboe
2022-07-27 4:09 Stephen Rothwell
2022-07-21 3:11 Stephen Rothwell
2022-07-21 4:23 ` Christoph Hellwig
2022-07-21 16:51 ` Jens Axboe
2022-07-15 4:02 Stephen Rothwell
2022-07-15 4:10 ` Al Viro
2022-07-15 14:42 ` Jens Axboe
2022-07-15 17:33 ` Linus Torvalds
2022-07-17 3:43 ` Al Viro
2022-05-23 2:49 Stephen Rothwell
2022-05-23 2:52 ` Jens Axboe
2022-05-23 6:05 ` Coly Li
2022-05-23 12:31 ` Jens Axboe
2022-05-04 1:40 Stephen Rothwell
2022-05-04 11:25 ` Jens Axboe
2022-03-09 2:16 Stephen Rothwell
2022-03-09 2:33 ` Jens Axboe
2022-03-09 2:42 ` Jens Axboe
2021-08-10 10:31 Stephen Rothwell
2021-08-10 10:52 ` Stephen Rothwell
2021-08-10 12:58 ` Christoph Hellwig
2021-08-10 13:01 ` Jens Axboe
2021-08-10 13:22 ` Stephen Rothwell
2021-02-23 1:42 Stephen Rothwell
2021-02-23 2:32 ` Jens Axboe
2021-02-02 2:57 Stephen Rothwell
2021-02-02 3:16 ` Stephen Rothwell
2021-02-02 6:55 ` Christoph Hellwig
2021-02-14 22:24 ` Stephen Rothwell
2020-12-14 4:18 Stephen Rothwell
2020-12-07 3:09 Stephen Rothwell
2020-12-07 20:09 ` Florent Revest
2020-12-14 20:29 ` Stephen Rothwell
2020-12-02 4:01 Stephen Rothwell
2020-12-02 7:19 ` Christoph Hellwig
2020-12-14 20:09 ` Stephen Rothwell
2020-12-14 20:12 ` Jens Axboe
2020-12-14 21:36 ` David Sterba
2020-12-14 21:43 ` Stephen Rothwell
2020-12-14 21:54 ` David Sterba
2020-12-14 22:01 ` Stephen Rothwell
2020-09-23 4:34 Stephen Rothwell
2020-07-15 2:14 Stephen Rothwell
2020-07-15 9:24 ` Geert Uytterhoeven
2020-07-15 15:08 ` Jens Axboe
2020-07-15 15:17 ` Geert Uytterhoeven
2020-07-15 15:22 ` Geert Uytterhoeven
2020-07-15 15:25 ` Jens Axboe
2020-07-15 15:08 ` Jens Axboe
2020-06-02 3:25 Stephen Rothwell
2020-05-25 5:08 Stephen Rothwell
2020-05-25 19:03 ` Jens Axboe
2020-05-26 4:36 ` Stephen Rothwell
2020-05-26 13:53 ` Jens Axboe
2020-05-22 11:32 Stephen Rothwell
2020-05-22 14:46 ` Jens Axboe
2020-05-14 8:57 Stephen Rothwell
2020-05-14 14:06 ` Jens Axboe
2020-05-11 4:27 Stephen Rothwell
2020-05-11 15:06 ` Jens Axboe
2020-05-11 15:17 ` Christoph Hellwig
2020-05-11 15:28 ` Jens Axboe
2020-05-08 5:28 Stephen Rothwell
2020-05-08 15:48 ` Jens Axboe
2020-03-12 2:54 Stephen Rothwell
2020-03-12 10:12 ` Matteo Croce
2020-03-12 13:07 ` Jens Axboe
2020-03-12 13:57 ` Matteo Croce
2020-03-13 7:24 ` Gao Xiang
2020-02-04 0:25 Stephen Rothwell
2020-02-04 0:28 ` Jens Axboe
2020-02-03 0:04 Stephen Rothwell
2020-02-03 4:12 ` Jens Axboe
2020-01-06 1:30 Stephen Rothwell
2020-01-07 4:04 ` Jens Axboe
2020-01-12 18:32 ` Al Viro
2020-01-13 17:09 ` Jens Axboe
2020-01-13 17:26 ` Jens Axboe
2019-10-28 2:59 Stephen Rothwell
2019-10-28 3:25 ` Jens Axboe
2019-07-11 5:15 Stephen Rothwell
2019-07-11 20:17 ` Tejun Heo
2019-07-11 20:36 ` Jens Axboe
2019-07-11 5:04 Stephen Rothwell
2019-06-21 3:56 Stephen Rothwell
2019-06-21 8:18 ` Christoph Hellwig
2019-06-21 8:36 ` Stephen Rothwell
2019-01-16 2:55 Stephen Rothwell
2019-01-16 2:48 Stephen Rothwell
2019-01-16 2:50 ` Ming Lei
2019-01-16 2:35 Stephen Rothwell
2019-01-16 2:48 ` Ming Lei
2018-07-31 3:07 Stephen Rothwell
2018-07-31 14:59 ` Jens Axboe
2018-07-26 4:56 Stephen Rothwell
2018-07-26 8:48 ` Christoph Hellwig
2018-07-26 8:45 ` Stephen Rothwell
2018-07-26 17:48 ` Jens Axboe
2018-07-26 17:56 ` Christoph Hellwig
2018-07-26 17:59 ` Steve Wise
2018-07-26 20:54 ` Bart Van Assche
2018-07-26 21:13 ` Jens Axboe
2018-07-26 12:32 ` Steve Wise
2018-07-26 22:16 ` Stephen Rothwell
2018-08-15 1:43 ` Stephen Rothwell
2017-08-24 3:32 Stephen Rothwell
2017-08-24 3:34 ` Stephen Rothwell
2017-08-24 8:44 ` Christoph Hellwig
2017-08-24 8:54 ` Stephen Rothwell
2017-06-28 8:04 Stephen Rothwell
2017-06-28 12:43 ` Jens Axboe
2017-06-28 14:01 ` Jens Axboe
2017-06-28 15:11 ` Jens Axboe
2017-06-28 21:33 ` Stephen Rothwell
2017-06-13 10:54 Stephen Rothwell
2017-06-15 14:50 ` Sebastian Ott
2017-06-19 9:00 ` Sebastian Ott
2017-06-20 1:45 ` Stephen Rothwell
2017-07-04 15:15 ` Guenter Roeck
2017-07-04 21:40 ` Stephen Rothwell
2017-06-13 4:10 Stephen Rothwell
2017-04-18 3:02 Stephen Rothwell
2017-05-02 1:07 ` Stephen Rothwell
2017-05-02 1:09 ` Jens Axboe
2017-05-02 1:37 ` Stephen Rothwell
2017-05-02 1:45 ` Jens Axboe
2017-01-30 1:43 Stephen Rothwell
2017-01-30 1:53 ` Jens Axboe
2017-01-30 3:07 ` Jens Axboe
2017-01-30 6:34 ` Christoph Hellwig
2016-12-01 2:55 Stephen Rothwell
2016-12-01 3:00 ` Jens Axboe
2016-12-01 3:02 ` Stephen Rothwell
2016-12-01 3:04 ` Jens Axboe
2016-11-08 3:21 Stephen Rothwell
2016-11-08 3:28 ` Jens Axboe
2016-09-19 6:18 Stephen Rothwell
2016-09-19 13:48 ` Christoph Hellwig
2016-09-19 14:22 ` Jens Axboe
2016-09-16 1:14 Stephen Rothwell
2016-09-16 4:13 ` Jens Axboe
2016-04-26 3:38 Stephen Rothwell
2016-04-26 13:30 ` Michal Marek
2016-04-26 13:56 ` Stephen Rothwell
[not found] ` <v3THaCMkCzylcv3TJavAje@videotron.ca>
2016-04-26 14:40 ` Nicolas Pitre
2016-04-26 14:41 ` Jens Axboe
2016-04-26 15:18 ` Stephen Rothwell
2016-04-26 20:48 ` Nicolas Pitre
2016-04-26 21:39 ` Stephen Rothwell
2016-04-27 9:02 ` Michal Marek
2016-04-27 13:46 ` Nicolas Pitre
2016-03-07 3:29 Stephen Rothwell
2015-12-02 16:19 Mark Brown
2015-12-02 16:45 ` Christoph Hellwig
2015-12-02 21:07 ` Jens Axboe
2015-12-02 21:14 ` Keith Busch
2015-12-02 21:27 ` Jens Axboe
2015-12-03 7:35 ` Christoph Hellwig
2015-12-03 8:39 ` Matias Bjørling
2015-12-03 9:06 ` Christoph Hellwig
2015-12-03 9:52 ` Matias Bjørling
2015-12-03 9:57 ` Christoph Hellwig
2015-12-03 10:09 ` Matias Bjørling
2015-12-03 10:21 ` Christoph Hellwig
2015-12-03 11:07 ` Matias Bjørling
2015-12-03 16:42 ` Christoph Hellwig
2015-12-04 12:16 ` Matias Bjørling
2015-10-06 1:43 Stephen Rothwell
2015-10-06 1:54 ` kbuild test robot
2015-10-06 7:20 ` Ming Lei
2015-07-30 4:17 Stephen Rothwell
2015-07-30 6:19 ` Christoph Hellwig
2015-07-30 12:24 ` Stephen Rothwell
2015-07-30 14:38 ` Drokin, Oleg
2015-02-09 4:25 Stephen Rothwell
2015-01-21 3:45 Stephen Rothwell
2014-11-17 3:44 Stephen Rothwell
2014-11-17 19:51 ` Jens Axboe
2014-11-11 2:12 Stephen Rothwell
2014-11-11 11:20 ` Fabian Frederick
2014-11-11 15:27 ` Jens Axboe
2014-11-14 16:19 ` Fabian Frederick
2013-11-26 2:30 Stephen Rothwell
2013-11-04 3:13 Stephen Rothwell
2013-11-04 3:23 ` Jens Axboe
2013-11-04 3:32 ` Jens Axboe
2013-11-04 3:39 ` Stephen Rothwell
2013-11-01 4:01 Stephen Rothwell
2013-02-06 3:06 Stephen Rothwell
2013-02-06 3:06 ` Stephen Rothwell
2013-02-06 8:33 ` Jens Axboe
2012-10-10 1:14 Stephen Rothwell
2012-09-27 3:27 Stephen Rothwell
2012-09-27 7:37 ` Jens Axboe
2011-12-19 3:19 Stephen Rothwell
2011-12-19 9:37 ` Jens Axboe
2011-12-19 16:41 ` Tejun Heo
2011-12-19 9:45 ` Sedat Dilek
2011-12-19 9:48 ` Jens Axboe
2011-12-19 11:32 ` Stephen Rothwell
2011-12-16 1:50 Stephen Rothwell
2011-12-16 8:20 ` Jens Axboe
2011-09-17 11:18 Stephen Rothwell
2011-07-04 3:48 Stephen Rothwell
2011-06-01 1:01 Stephen Rothwell
2011-06-01 6:26 ` Jens Axboe
2011-06-01 13:43 ` Konrad Rzeszutek Wilk
2011-03-25 3:30 Stephen Rothwell
2011-03-25 4:08 ` Akinobu Mita
2011-03-25 5:25 ` Stephen Rothwell
2011-03-14 5:19 Stephen Rothwell
2011-03-16 23:32 ` Stephen Rothwell
2011-03-17 10:18 ` Jens Axboe
2011-03-17 10:36 ` David Woodhouse
2011-03-17 10:45 ` Jens Axboe
2011-03-21 23:33 ` Stephen Rothwell
2011-03-10 3:08 Stephen Rothwell
2011-03-10 7:15 ` Jens Axboe
2011-03-07 2:39 Stephen Rothwell
2011-01-07 0:05 Stephen Rothwell
2011-01-07 7:32 ` Jens Axboe
2011-01-07 10:52 ` Sedat Dilek
2011-01-07 12:17 ` Stephen Rothwell
2011-01-07 13:19 ` Sedat Dilek
2011-01-07 14:22 ` Stephen Rothwell
2011-01-07 15:08 ` Jens Axboe
2011-01-07 18:04 ` Sedat Dilek
2011-01-07 18:20 ` Sedat Dilek
2010-12-23 1:53 Stephen Rothwell
2010-12-23 22:36 ` Nicholas A. Bellinger
2010-10-11 3:18 Stephen Rothwell
2010-10-23 2:51 ` Stephen Rothwell
2010-09-17 1:37 Stephen Rothwell
2010-09-17 3:19 ` Christoph Hellwig
2010-08-09 1:28 Stephen Rothwell
2010-08-09 1:50 ` Jens Axboe
2010-08-05 1:47 Stephen Rothwell
2010-08-05 6:35 ` Jens Axboe
2010-08-03 3:12 Stephen Rothwell
2010-08-03 7:46 ` Jens Axboe
2010-08-03 8:26 ` Christoph Hellwig
2010-05-18 3:37 Stephen Rothwell
2010-05-18 8:56 ` Jens Axboe
2010-05-18 10:20 ` Stephen Rothwell
2010-05-18 10:50 ` Jens Axboe
2010-04-29 3:52 Stephen Rothwell
2010-04-29 7:31 ` Jens Axboe
2010-04-28 3:52 Stephen Rothwell
2010-04-28 5:34 ` Jens Axboe
2010-04-15 2:42 Stephen Rothwell
2010-04-15 5:23 ` Divyesh Shah
2010-04-15 6:16 ` Stephen Rothwell
2010-04-15 6:56 ` Jens Axboe
2010-02-23 2:26 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506150707.618f013d@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=adas@redhat.com \
--cc=agruenba@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.