Re: [PATCH v5 1/2] documentation: add tutorial for first contribution

From: Emily Shaffer <emilyshaffer@google.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
	Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v5 1/2] documentation: add tutorial for first contribution
Date: Tue, 7 May 2019 16:25:55 -0700	[thread overview]
Message-ID: <20190507232555.GA188866@google.com> (raw)
In-Reply-To: <20190507213040.151799-2-emilyshaffer@google.com>

> +Add a line to `#include "config.h"`. Then, add the following bits to the
> +function body:
> +
> +----
> +	const char *cfg_name;
> +
> +...
> +
> +	git_config(git_default_config, NULL)
> +	if (git_config_get_string_const("user.name", &cfg_name) > 0) {
> +		printf(_("No name is found in config\n"));
> +	} else {
> +		printf(_("Your name: %s\n"), cfg_name);
> +	}

Just noticed the braces here, too. I have removed them from my local
copy and will upload again if I hear other comments warranting a v6.

 - Emily