From: Sasha Levin <sashal@kernel.org>
To: Eric Wheeler <stable@lists.ewheeler.net>
Cc: Paolo Valente <paolo.valente@linaro.org>,
Jens Axboe <axboe@kernel.dk>,
"open list:BFQ I/O SCHEDULER" <linux-block@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Eric Wheeler <bfq@linux.ewheeler.net>,
stable@vger.kernel.org
Subject: Re: [PATCH] bfq: backport: update internal depth state when queue depth changes
Date: Fri, 10 May 2019 16:18:55 -0400 [thread overview]
Message-ID: <20190510201855.GB14410@sasha-vm> (raw)
In-Reply-To: <1557510992-18506-1-git-send-email-stable@lists.ewheeler.net>
On Fri, May 10, 2019 at 10:56:32AM -0700, Eric Wheeler wrote:
>From: Jens Axboe <axboe@kernel.dk>
>
>commit 77f1e0a52d26242b6c2dba019f6ebebfb9ff701e upstream
>
>A previous commit moved the shallow depth and BFQ depth map calculations
>to be done at init time, moving it outside of the hotter IO path. This
>potentially causes hangs if the users changes the depth of the scheduler
>map, by writing to the 'nr_requests' sysfs file for that device.
>
>Add a blk-mq-sched hook that allows blk-mq to inform the scheduler if
>the depth changes, so that the scheduler can update its internal state.
>
>Signed-off-by: Eric Wheeler <bfq@linux.ewheeler.net>
>Tested-by: Kai Krakow <kai@kaishome.de>
>Reported-by: Paolo Valente <paolo.valente@linaro.org>
>Fixes: f0635b8a416e ("bfq: calculate shallow depths at init time")
>Signed-off-by: Jens Axboe <axboe@kernel.dk>
>Cc: stable@vger.kernel.org
I wasn't clear on what was backported here, so I've queued the upstream
version on 4.19 and 4.14, it doesn't seem to be relevant to older
branches.
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-05-10 20:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 17:56 [PATCH] bfq: backport: update internal depth state when queue depth changes Eric Wheeler
2019-05-10 20:18 ` Sasha Levin [this message]
2019-05-10 23:17 ` Eric Wheeler
2019-05-10 23:58 ` Holger Hoffstätte
2019-05-13 7:03 ` Greg KH
2019-05-13 13:09 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510201855.GB14410@sasha-vm \
--to=sashal@kernel.org \
--cc=axboe@kernel.dk \
--cc=bfq@linux.ewheeler.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=stable@lists.ewheeler.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.