From: Mark Brown <broonie@kernel.org>
To: "Derek [方德義]" <derek.fang@realtek.com>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"Albert Chen" <albertchen@realtek.com>,
"bard.liao@intel.com" <bard.liao@intel.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Flove(HsinFu)" <flove@realtek.com>
Subject: Re: [PATCH] ASoC: rt1308: Add RT1308 amplifier driver
Date: Mon, 13 May 2019 15:56:08 +0100 [thread overview]
Message-ID: <20190513145608.GA5168@sirena.org.uk> (raw)
In-Reply-To: <BC6F7617C38F3E4E8CA887E07B35B82805B13EE2@RTITMBSVM07.realtek.com.tw>
[-- Attachment #1.1: Type: text/plain, Size: 1100 bytes --]
On Mon, May 13, 2019 at 01:54:08PM +0000, Derek [方德義] wrote:
> > I'm confused about what this limit is - is it just some arbatrary limit
> > imposed in case some board has problems or is it an actual limit that
> > comes from the chip? If it's a "just in case" limit then the board
> > should be the one doing the limiting, yes people can break things but
> > it's difficult to get decision like that done sensibly in the CODEC
> > driver in a way that works for everything and the general expectation is
> > that this is all for use by system integrators rather than end users.
> It is an actual limit that comes from the chip.
If there is an actual limit in the chip the driver just shouldn't expose
anything beyond what that limit is - the original thing I was calling
out was that you're just hard coding a value for this setting into the
driver, that just means that the expectation is that the values should
be user settable within whatever the chip can support. If there's
settings that can't be supported at all the driver doesn't need to
pretend to offer them.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2019-05-13 14:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 2:22 [PATCH] ASoC: rt1308: Add RT1308 amplifier driver derek.fang
[not found] ` <20190416153510.GE4834@sirena.org.uk>
[not found] ` <BC6F7617C38F3E4E8CA887E07B35B8280116192E@RTITMBSVM07.realtek.com.tw>
2019-04-17 15:05 ` Mark Brown
2019-04-23 13:39 ` Derek [方德義]
2019-05-08 6:45 ` Mark Brown
2019-05-08 13:17 ` Derek [方德義]
2019-05-12 8:06 ` Mark Brown
2019-05-13 13:54 ` Derek [方德義]
2019-05-13 14:56 ` Mark Brown [this message]
2019-05-14 11:10 ` Derek [方德義]
2019-05-15 16:14 ` Mark Brown
2019-05-16 13:46 ` Derek [方德義]
2019-05-16 16:52 ` Mark Brown
2019-04-17 12:05 derek.fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513145608.GA5168@sirena.org.uk \
--to=broonie@kernel.org \
--cc=albertchen@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.