From: Sultan Alsawaf <sultan@kerneltoast.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: "Christian Brauner" <christian@brauner.io>,
"Daniel Colascione" <dancol@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Tim Murray" <timmurray@google.com>,
"Michal Hocko" <mhocko@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
linux-mm <linux-mm@kvack.org>,
kernel-team <kernel-team@android.com>,
"Andy Lutomirski" <luto@amacapital.net>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Kees Cook" <keescook@chromium.org>,
"Joel Fernandes" <joel@joelfernandes.org>
Subject: Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android
Date: Mon, 13 May 2019 09:45:55 -0700 [thread overview]
Message-ID: <20190513164555.GA30128@sultan-box.localdomain> (raw)
In-Reply-To: <20190510151024.GA21421@redhat.com>
On Fri, May 10, 2019 at 05:10:25PM +0200, Oleg Nesterov wrote:
> I am starting to think I am ;)
>
> If you have task1 != task2 this code
>
> task_lock(task1);
> task_lock(task2);
>
> should trigger print_deadlock_bug(), task1->alloc_lock and task2->alloc_lock are
> the "same" lock from lockdep pov, held_lock's will have the same hlock_class().
Okay, I've stubbed out debug_locks_off(), and lockdep is now complaining about a
bunch of false positives so it is _really_ enabled this time. I grepped for
lockdep last time to try and find a concise way to show over email that lockdep
didn't complain, but that backfired. Here is better evidence:
taimen:/ # dmesg | grep simple_lmk
[ 58.349917] simple_lmk: Killing droid.deskclock with adj 906 to free 47548 KiB
[ 58.354748] simple_lmk: Killing .android.dialer with adj 906 to free 36576 KiB
[ 58.355030] simple_lmk: Killing rbandroid.sleep with adj 904 to free 50016 KiB
[ 58.582833] simple_lmk: Killing oadcastreceiver with adj 904 to free 43044 KiB
[ 58.587731] simple_lmk: Killing .apps.wellbeing with adj 902 to free 48128 KiB
[ 58.588084] simple_lmk: Killing android.carrier with adj 902 to free 43636 KiB
[ 58.671857] simple_lmk: Killing ndroid.keychain with adj 902 to free 39992 KiB
[ 58.675622] simple_lmk: Killing gs.intelligence with adj 900 to free 49572 KiB
[ 58.675770] simple_lmk: Killing le.modemservice with adj 800 to free 41976 KiB
[ 58.762060] simple_lmk: Killing ndroid.settings with adj 700 to free 74708 KiB
[ 58.763238] simple_lmk: Killing roid.apps.turbo with adj 700 to free 54660 KiB
[ 58.873337] simple_lmk: Killing d.process.acore with adj 700 to free 48540 KiB
[ 58.873513] simple_lmk: Killing d.process.media with adj 500 to free 46188 KiB
[ 58.873713] simple_lmk: Killing putmethod.latin with adj 200 to free 67304 KiB
[ 59.014046] simple_lmk: Killing android.vending with adj 201 to free 54900 KiB
[ 59.017623] simple_lmk: Killing rak.mibandtools with adj 201 to free 44552 KiB
[ 59.018423] simple_lmk: Killing eport.trebuchet with adj 100 to free 106208 KiB
[ 59.223633] simple_lmk: Killing id.printspooler with adj 900 to free 39664 KiB
[ 59.223762] simple_lmk: Killing gle.android.gms with adj 100 to free 64176 KiB
[ 70.955204] simple_lmk: Killing .apps.translate with adj 906 to free 47564 KiB
[ 70.955633] simple_lmk: Killing cloudprint:sync with adj 906 to free 31932 KiB
[ 70.955787] simple_lmk: Killing oid.apps.photos with adj 904 to free 50204 KiB
[ 71.060789] simple_lmk: Killing ecamera.android with adj 906 to free 32232 KiB
[ 71.061074] simple_lmk: Killing webview_service with adj 906 to free 26028 KiB
[ 71.061199] simple_lmk: Killing com.whatsapp with adj 904 to free 49484 KiB
[ 71.190625] simple_lmk: Killing rbandroid.sleep with adj 906 to free 54724 KiB
[ 71.190775] simple_lmk: Killing android.vending with adj 906 to free 39848 KiB
[ 71.191303] simple_lmk: Killing m.facebook.orca with adj 904 to free 72296 KiB
[ 71.342042] simple_lmk: Killing droid.deskclock with adj 902 to free 49284 KiB
[ 71.342240] simple_lmk: Killing .apps.wellbeing with adj 900 to free 47632 KiB
[ 71.342529] simple_lmk: Killing le.modemservice with adj 800 to free 33648 KiB
[ 71.482391] simple_lmk: Killing d.process.media with adj 800 to free 40676 KiB
[ 71.482511] simple_lmk: Killing rdog.challegram with adj 700 to free 71920 KiB
taimen:/ #
The first simple_lmk message appears at 58.349917. And based on the timestamps,
it's clear that simple_lmk called task_lock() for multiple different tasks,
which is the pattern you think should cause lockdep to complain. But here is the
full dmesg starting from that point:
[ 58.349917] simple_lmk: Killing droid.deskclock with adj 906 to free 47548 KiB
[ 58.354748] simple_lmk: Killing .android.dialer with adj 906 to free 36576 KiB
[ 58.355030] simple_lmk: Killing rbandroid.sleep with adj 904 to free 50016 KiB
[ 58.432654] binder_alloc: 2284: binder_alloc_buf failed to map pages in userspace, no vma
[ 58.432671] binder: 1206:1218 transaction failed 29189/-3, size 76-0 line 3189
[ 58.582833] simple_lmk: Killing oadcastreceiver with adj 904 to free 43044 KiB
[ 58.587731] simple_lmk: Killing .apps.wellbeing with adj 902 to free 48128 KiB
[ 58.588084] simple_lmk: Killing android.carrier with adj 902 to free 43636 KiB
[ 58.590785] binder: undelivered transaction 58370, process died.
[ 58.671857] simple_lmk: Killing ndroid.keychain with adj 902 to free 39992 KiB
[ 58.675622] simple_lmk: Killing gs.intelligence with adj 900 to free 49572 KiB
[ 58.675770] simple_lmk: Killing le.modemservice with adj 800 to free 41976 KiB
[ 58.736678] binder: undelivered transaction 58814, process died.
[ 58.736733] binder: release 3099:3128 transaction 57832 in, still active
[ 58.736744] binder: send failed reply for transaction 57832 to 1876:3090
[ 58.736761] binder: undelivered TRANSACTION_COMPLETE
[ 58.736766] binder: undelivered transaction 58752, process died.
[ 58.762060] simple_lmk: Killing ndroid.settings with adj 700 to free 74708 KiB
[ 58.763238] simple_lmk: Killing roid.apps.turbo with adj 700 to free 54660 KiB
[ 58.863590] binder: release 1876:3089 transaction 58117 out, still active
[ 58.863606] binder: undelivered TRANSACTION_COMPLETE
[ 58.873337] simple_lmk: Killing d.process.acore with adj 700 to free 48540 KiB
[ 58.873513] simple_lmk: Killing d.process.media with adj 500 to free 46188 KiB
[ 58.873713] simple_lmk: Killing putmethod.latin with adj 200 to free 67304 KiB
[ 59.014046] simple_lmk: Killing android.vending with adj 201 to free 54900 KiB
[ 59.017623] simple_lmk: Killing rak.mibandtools with adj 201 to free 44552 KiB
[ 59.018423] simple_lmk: Killing eport.trebuchet with adj 100 to free 106208 KiB
[ 59.028460] binder: 1206:1206 transaction failed 29189/-22, size 100-0 line 3052
[ 59.142592] binder_alloc: 2814: binder_alloc_buf, no vma
[ 59.142620] binder: 1206:1218 transaction failed 29189/-3, size 76-0 line 3189
[ 59.223633] simple_lmk: Killing id.printspooler with adj 900 to free 39664 KiB
[ 59.223762] simple_lmk: Killing gle.android.gms with adj 100 to free 64176 KiB
[ 59.540176] binder: undelivered transaction 59447, process died.
[ 59.540763] binder: undelivered transaction 59446, process died.
[ 59.815404] binder: 1206:3140 transaction failed 29189/0, size 12-0 line 2992
[ 59.815418] binder: send failed reply for transaction 58117, target dead
[ 60.977609] binder: 2105:2308 transaction failed 29189/-22, size 168-0 line 3052
[ 63.040202] FG: fg_get_battery_temp: batt temperature original:350, tuned:309
[ 63.040219] lge_battery: bm_watch_work: PRESENT:1, CHG_STAT:1, THM_STAT:2, BAT_TEMP:309, BAT_VOLT:4148182, VOTE_CUR:1000000, SET_CUR:1000000
[ 63.076086] msm-dwc3 a800000.ssusb: Avail curr from USB = 2
[ 63.077278] PMI: smblib_handle_switcher_power_ok: Weak charger detected: voting 500mA ICL
[ 63.080014] PMI: smblib_handle_switcher_power_ok: Reverse boost detected: voting 0mA to suspend input
[ 63.081886] FG: fg_get_battery_temp: batt temperature original:350, tuned:310
[ 63.093639] fts_touch 5-0049: [FTS] Received Charger Disconnected Event
[ 63.104656] healthd: battery l=100 v=4148 t=31.0 h=2 st=3 c=748 fc=3229000 cc=289 chg=
[ 63.122546] healthd: battery l=100 v=4148 t=31.0 h=2 st=3 c=748 fc=3229000 cc=289 chg=
[ 63.135620] FG: fg_get_battery_temp: batt temperature original:350, tuned:310
[ 63.156383] FG: fg_get_battery_temp: batt temperature original:350, tuned:310
[ 63.156897] FG: fg_get_battery_temp: batt temperature original:350, tuned:310
[ 63.160481] FG: fg_get_battery_temp: batt temperature original:350, tuned:310
[ 63.185029] healthd: battery l=100 v=4148 t=31.0 h=2 st=3 c=748 fc=3229000 cc=289 chg=
[ 63.189015] healthd: battery l=100 v=4148 t=31.0 h=2 st=3 c=748 fc=3229000 cc=289 chg=
[ 63.212484] lge_battery: bm_check_status: wake_unlocked: present[0] chg_state[2] vbus[0]
[ 63.213039] FG: fg_get_battery_temp: batt temperature original:350, tuned:310
[ 63.231096] FG: fg_get_battery_temp: batt temperature original:350, tuned:310
[ 63.233981] healthd: battery l=100 v=4148 t=31.0 h=2 st=3 c=748 fc=3229000 cc=289 chg=
[ 63.234663] msm-dwc3 a800000.ssusb: dwc3_msm_suspend: Calling suspend 1996
[ 63.249755] msm-dwc3 a800000.ssusb: DWC3 in low power mode
[ 63.250247] healthd: battery l=100 v=4148 t=31.0 h=2 st=3 c=748 fc=3229000 cc=289 chg=
[ 63.250430] android_work: sent uevent USB_STATE=DISCONNECTED
[ 63.294456] msm-dwc3 a800000.ssusb: Avail curr from USB = 0
[ 70.492114] binder: undelivered transaction 86938, process died.
[ 70.955204] simple_lmk: Killing .apps.translate with adj 906 to free 47564 KiB
[ 70.955633] simple_lmk: Killing cloudprint:sync with adj 906 to free 31932 KiB
[ 70.955787] simple_lmk: Killing oid.apps.photos with adj 904 to free 50204 KiB
[ 71.060789] simple_lmk: Killing ecamera.android with adj 906 to free 32232 KiB
[ 71.061074] simple_lmk: Killing webview_service with adj 906 to free 26028 KiB
[ 71.061199] simple_lmk: Killing com.whatsapp with adj 904 to free 49484 KiB
[ 71.164996] binder: undelivered transaction 87881, process died.
[ 71.190625] simple_lmk: Killing rbandroid.sleep with adj 906 to free 54724 KiB
[ 71.190775] simple_lmk: Killing android.vending with adj 906 to free 39848 KiB
[ 71.191303] simple_lmk: Killing m.facebook.orca with adj 904 to free 72296 KiB
[ 71.342042] simple_lmk: Killing droid.deskclock with adj 902 to free 49284 KiB
[ 71.342240] simple_lmk: Killing .apps.wellbeing with adj 900 to free 47632 KiB
[ 71.342529] simple_lmk: Killing le.modemservice with adj 800 to free 33648 KiB
[ 71.482391] simple_lmk: Killing d.process.media with adj 800 to free 40676 KiB
[ 71.482511] simple_lmk: Killing rdog.challegram with adj 700 to free 71920 KiB
No lockdep warnings!
Sultan
next prev parent reply other threads:[~2019-05-13 16:46 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 20:34 [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android Sultan Alsawaf
2019-03-10 20:34 ` Sultan Alsawaf
2019-03-10 21:03 ` Greg Kroah-Hartman
2019-03-10 21:26 ` Sultan Alsawaf
2019-03-11 16:32 ` Joel Fernandes
2019-03-11 16:37 ` Joel Fernandes
2019-03-11 17:43 ` Michal Hocko
2019-03-11 17:58 ` Sultan Alsawaf
2019-03-11 20:10 ` Suren Baghdasaryan
2019-03-11 20:46 ` Sultan Alsawaf
2019-03-11 21:11 ` Joel Fernandes
2019-03-11 21:46 ` Sultan Alsawaf
2019-03-11 22:15 ` Suren Baghdasaryan
2019-03-11 22:36 ` Sultan Alsawaf
2019-03-12 8:05 ` Michal Hocko
2019-03-12 14:36 ` Suren Baghdasaryan
2019-03-12 15:25 ` Matthew Wilcox
2019-03-12 15:33 ` Michal Hocko
2019-03-12 15:39 ` Michal Hocko
2019-03-12 16:37 ` Sultan Alsawaf
2019-03-12 16:48 ` Michal Hocko
2019-03-12 16:58 ` Michal Hocko
2019-03-12 17:15 ` Suren Baghdasaryan
2019-03-12 17:17 ` Tim Murray
2019-03-12 17:45 ` Sultan Alsawaf
2019-03-12 18:43 ` Tim Murray
2019-03-12 18:50 ` Christian Brauner
2019-03-14 17:47 ` Joel Fernandes
2019-03-14 20:49 ` Sultan Alsawaf
2019-03-15 2:54 ` Joel Fernandes
2019-03-15 3:43 ` Sultan Alsawaf
2019-03-15 3:16 ` Steven Rostedt
2019-03-15 3:45 ` Sultan Alsawaf
2019-03-15 4:36 ` Daniel Colascione
2019-03-15 13:36 ` Joel Fernandes
2019-03-15 15:56 ` Suren Baghdasaryan
2019-03-15 16:12 ` Daniel Colascione
2019-03-15 16:43 ` Steven Rostedt
2019-03-15 17:17 ` Daniel Colascione
2019-03-15 18:03 ` Christian Brauner
2019-03-15 18:13 ` Joel Fernandes
2019-03-15 18:24 ` Christian Brauner
2019-03-15 18:49 ` Joel Fernandes
2019-03-16 17:31 ` Suren Baghdasaryan
2019-03-16 18:00 ` Daniel Colascione
2019-03-16 18:57 ` Christian Brauner
2019-03-16 19:37 ` Suren Baghdasaryan
2019-03-17 1:53 ` Joel Fernandes
2019-03-17 11:42 ` Christian Brauner
2019-03-17 15:40 ` Daniel Colascione
2019-03-18 0:29 ` Christian Brauner
2019-03-18 23:50 ` Joel Fernandes
2019-03-19 22:14 ` Christian Brauner
2019-03-19 22:26 ` Joel Fernandes
2019-03-19 22:48 ` Daniel Colascione
2019-03-19 23:10 ` Christian Brauner
2019-03-20 1:52 ` Joel Fernandes
2019-03-20 2:42 ` pidfd design Daniel Colascione
2019-03-20 3:59 ` Christian Brauner
2019-03-20 7:02 ` Daniel Colascione
2019-03-20 11:33 ` Joel Fernandes
2019-03-20 11:33 ` Joel Fernandes
2019-03-20 18:26 ` Christian Brauner
2019-03-20 18:38 ` Daniel Colascione
2019-03-20 18:51 ` Christian Brauner
2019-03-20 18:58 ` Andy Lutomirski
2019-03-20 19:14 ` Christian Brauner
2019-03-20 19:40 ` Daniel Colascione
2019-03-21 17:02 ` Andy Lutomirski
2019-03-25 20:13 ` Jann Horn
2019-03-25 20:13 ` Jann Horn
2019-03-25 20:23 ` Daniel Colascione
2019-03-25 20:23 ` Daniel Colascione
2019-03-25 23:42 ` Andy Lutomirski
2019-03-25 23:42 ` Andy Lutomirski
2019-03-25 23:45 ` Christian Brauner
2019-03-25 23:45 ` Christian Brauner
2019-03-26 0:00 ` Andy Lutomirski
2019-03-26 0:00 ` Andy Lutomirski
2019-03-26 0:12 ` Christian Brauner
2019-03-26 0:12 ` Christian Brauner
2019-03-26 0:24 ` Andy Lutomirski
2019-03-26 0:24 ` Andy Lutomirski
2019-03-28 9:21 ` Christian Brauner
2019-03-28 9:21 ` Christian Brauner
2019-03-20 19:19 ` Joel Fernandes
2019-03-20 19:29 ` Daniel Colascione
2019-03-24 14:44 ` Serge E. Hallyn
2019-03-24 18:48 ` Joel Fernandes
2019-03-20 19:11 ` Joel Fernandes
2019-05-07 2:16 ` [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android Sultan Alsawaf
2019-05-07 2:16 ` Sultan Alsawaf
2019-05-07 7:04 ` Greg Kroah-Hartman
2019-05-07 7:27 ` Sultan Alsawaf
2019-05-07 7:43 ` Greg Kroah-Hartman
2019-05-07 8:12 ` Sultan Alsawaf
2019-05-07 10:58 ` Christian Brauner
2019-05-07 16:28 ` Suren Baghdasaryan
2019-05-07 16:38 ` Christian Brauner
2019-05-07 16:53 ` Sultan Alsawaf
2019-05-07 20:01 ` Suren Baghdasaryan
2019-05-07 18:46 ` Joel Fernandes
2019-05-07 17:17 ` Sultan Alsawaf
2019-05-07 17:29 ` Greg Kroah-Hartman
2019-05-07 11:09 ` Greg Kroah-Hartman
2019-05-07 12:26 ` Michal Hocko
2019-05-07 15:31 ` Oleg Nesterov
2019-05-07 16:35 ` Sultan Alsawaf
2019-05-09 15:56 ` Oleg Nesterov
2019-05-09 18:33 ` Sultan Alsawaf
2019-05-10 15:10 ` Oleg Nesterov
2019-05-13 16:45 ` Sultan Alsawaf [this message]
2019-05-14 16:44 ` Steven Rostedt
2019-05-14 17:31 ` Sultan Alsawaf
2019-05-15 14:58 ` Oleg Nesterov
2019-05-15 17:27 ` Sultan Alsawaf
2019-05-15 17:27 ` Sultan Alsawaf
2019-05-15 18:32 ` Steven Rostedt
2019-05-15 18:52 ` Sultan Alsawaf
2019-05-15 20:09 ` Steven Rostedt
2019-05-16 13:54 ` Oleg Nesterov
2019-03-17 16:35 ` Serge E. Hallyn
2019-03-17 17:11 ` Daniel Colascione
2019-03-17 17:16 ` Serge E. Hallyn
2019-03-17 22:02 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513164555.GA30128@sultan-box.localdomain \
--to=sultan@kerneltoast.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=dancol@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=maco@android.com \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=serge@hallyn.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.