From: Jeff King <peff@peff.net>
To: Eric Wong <e@80x24.org>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [WIP] repack leaving stale entries in objects/info/packs
Date: Wed, 15 May 2019 17:48:06 -0400 [thread overview]
Message-ID: <20190515214806.GA31693@sigill.intra.peff.net> (raw)
In-Reply-To: <20190515203839.zixx23bwzeyto6a3@dcvr>
On Wed, May 15, 2019 at 08:38:39PM +0000, Eric Wong wrote:
> I've also noticed objects/info/packs contains stale entries
> after repack/gc runs on current git.
>
> Tried adding reprepare_packed_git before update_server_info,
> but that didn't seem to work; so maybe something isn't cleared.
> Might have time to investigate more this week, might not...
We never delete entries from the in-memory packed_git list; a reprepare
only adds to the list. You'd need to teach update_server_info() to
ignore packs which are no longer present (or switch to exec-ing a
separate update-server-info binary).
-Peff
next prev parent reply other threads:[~2019-05-15 21:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 1:34 [PATCH] update-server-info: avoid needless overwrites Eric Wong
2019-05-11 7:35 ` Eric Sunshine
2019-05-11 20:47 ` [PATCH v2] " Eric Wong
2019-05-11 21:17 ` [PATCH] " Eric Wong
2019-05-11 23:37 ` Ævar Arnfjörð Bjarmason
2019-05-12 0:38 ` Eric Wong
2019-05-12 4:08 ` Jeff King
2019-05-12 7:16 ` Ævar Arnfjörð Bjarmason
2019-05-14 9:47 ` Jeff King
2019-05-14 10:33 ` Ævar Arnfjörð Bjarmason
2019-05-14 11:24 ` Jeff King
2019-05-14 11:57 ` Ævar Arnfjörð Bjarmason
2019-05-14 11:50 ` Eric Wong
2019-05-14 12:13 ` dumb HTTP things I want to do Eric Wong
2019-05-14 12:27 ` Jeff King
2019-05-14 12:19 ` [PATCH] update-server-info: avoid needless overwrites Ævar Arnfjörð Bjarmason
2019-05-14 12:29 ` Jeff King
2019-05-15 0:45 ` [PATCH 2/1] server-info: conditionally update on fetch Eric Wong
2019-05-15 20:38 ` [WIP] repack leaving stale entries in objects/info/packs Eric Wong
2019-05-15 21:48 ` Jeff King [this message]
2019-05-23 8:59 ` [PATCH] server-info: do not list unlinked packs Eric Wong
2019-05-23 10:24 ` Jeff King
2019-05-23 17:27 ` [PATCH v2] " Eric Wong
2019-05-24 6:05 ` Jeff King
2019-05-24 7:34 ` Ævar Arnfjörð Bjarmason
2019-05-13 23:17 ` [PATCH v3] update-server-info: avoid needless overwrites Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515214806.GA31693@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.