From: Wei Yang <richardw.yang@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com,
Wei Yang <richardw.yang@linux.intel.com>,
Wei Yang <richard.weiyang@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI
Date: Mon, 20 May 2019 08:35:14 +0800 [thread overview]
Message-ID: <20190520003514.GB18144@richard> (raw)
In-Reply-To: <20190517162903.4fc94708@Igors-MacBook-Pro>
On Fri, May 17, 2019 at 04:29:03PM +0200, Igor Mammedov wrote:
>On Fri, 17 May 2019 12:59:57 +0000
>Wei Yang <richard.weiyang@gmail.com> wrote:
>
>> On Fri, May 17, 2019 at 01:11:16PM +0200, Igor Mammedov wrote:
>> >On Fri, 17 May 2019 08:51:14 +0800
>> >Wei Yang <richardw.yang@linux.intel.com> wrote:
>> >
>> >> Pointed out by Philippe Mathieu-Daud?? <philmd@redhat.com>.
>> >>
>> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> >> ---
>> >> hw/acpi/Kconfig | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig
>> >> index 7265843cc3..7c59cf900b 100644
>> >> --- a/hw/acpi/Kconfig
>> >> +++ b/hw/acpi/Kconfig
>> >> @@ -25,7 +25,7 @@ config ACPI_NVDIMM
>> >>
>> >> config ACPI_PCI
>> >> bool
>> >> - depends on ACPI
>> >> + depends on ACPI && PCI
>> >>
>> >> config ACPI_VMGENID
>> >> bool
>> >
>> >are you sure you didn't miss anything?
>> >
>>
>> This patch is based on the comment in
>> http://qemu.11.n7.nabble.com/PATCH-v4-0-6-Extract-build-mcfg-tt650106.html#a655913
>>
>> My understanding is not correct?
>
>That wasn't the end of discussion, it continued on until Philippe suggested
>the below changes
>
Yep, just see the latest reply.
>>
>> >On Fri, 17 May 2019 10:37:42 +0200
>> >Philippe Mathieu-Daud?? <philmd@redhat.com> wrote:
>> >
>> >[...]
>> >>
>> >> config ARM_VIRT
>> >> ...
>> >> select ACPI_PCI
>> >>
>> >> config ACPI_PCI
>> >> bool
>> >> depends on ACPI && PCI
>> >>
>> >
>> >
>>
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2019-05-20 0:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 0:51 [Qemu-devel] [PATCH] hw/acpi: ACPI_PCI should depends on both ACPI and PCI Wei Yang
2019-05-17 1:44 ` Richard Henderson
2019-05-17 11:11 ` Igor Mammedov
2019-05-17 12:59 ` Wei Yang
2019-05-17 14:29 ` Igor Mammedov
2019-05-20 0:35 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520003514.GB18144@richard \
--to=richardw.yang@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.