From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 07/20] xfs: factor out log buffer writing from xlog_sync
Date: Fri, 24 May 2019 08:14:36 +0200 [thread overview]
Message-ID: <20190524061436.GA2235@lst.de> (raw)
In-Reply-To: <20190523230445.GT29573@dread.disaster.area>
On Fri, May 24, 2019 at 09:04:45AM +1000, Dave Chinner wrote:
> > +STATIC void
> > +xlog_write_iclog(
> > + struct xlog *log,
> > + struct xlog_in_core *iclog,
> > + struct xfs_buf *bp,
> > + uint64_t bno,
> > + bool flush)
>
> Can you rename this to need_flush here and in xlog_sync()? I kept
> having to check whether it meant "we need a flush" or "we've
> already done a flush" while reading the patch.
Ok.
> But on the extra buffer, we don't set it's I/O length at all....
>
> Oh, the setting of the IO length is hidden inside
> xfs_buf_associate_memory(). Can you add a comment indicating that
> this is why we omit the setting of the io length for the extra
> buffer?
Well, for one this is how we've always done it, and second we remove
this whole thing and xfs_buf_associate_memory a few patches down the
road. I'd rather not bother writing a comment here.
next prev parent reply other threads:[~2019-05-24 6:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 17:37 use bios directly in the log code v2 Christoph Hellwig
2019-05-23 17:37 ` [PATCH 01/20] xfs: remove the no-op spinlock_destroy stub Christoph Hellwig
2019-05-23 22:31 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 02/20] xfs: remove the never used _XBF_COMPOUND flag Christoph Hellwig
2019-05-23 22:31 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 03/20] xfs: renumber XBF_WRITE_FAIL Christoph Hellwig
2019-05-23 22:32 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 04/20] xfs: make mem_to_page available outside of xfs_buf.c Christoph Hellwig
2019-05-23 22:33 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 05/20] xfs: reformat xlog_get_lowest_lsn Christoph Hellwig
2019-05-23 22:34 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 06/20] xfs: don't use REQ_PREFLUSH for split log writes Christoph Hellwig
2019-05-23 22:39 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 07/20] xfs: factor out log buffer writing from xlog_sync Christoph Hellwig
2019-05-23 23:04 ` Dave Chinner
2019-05-24 6:14 ` Christoph Hellwig [this message]
2019-05-23 17:37 ` [PATCH 08/20] xfs: factor out splitting of an iclog " Christoph Hellwig
2019-05-23 23:17 ` Dave Chinner
2019-05-24 6:16 ` Christoph Hellwig
2019-05-23 17:37 ` [PATCH 09/20] xfs: factor out iclog size calculation " Christoph Hellwig
2019-05-23 23:25 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 10/20] xfs: update both stat counters together in xlog_sync Christoph Hellwig
2019-05-23 23:25 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 11/20] xfs: remove the syncing argument from xlog_verify_iclog Christoph Hellwig
2019-05-23 23:27 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 12/20] xfs: make use of the l_targ field in struct xlog Christoph Hellwig
2019-05-23 23:31 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 13/20] xfs: use bios directly to write log buffers Christoph Hellwig
2019-05-23 17:37 ` [PATCH 14/20] xfs: move the log ioend workqueue to struct xlog Christoph Hellwig
2019-05-23 17:37 ` [PATCH 15/20] xfs: return an offset instead of a pointer from xlog_align Christoph Hellwig
2019-05-23 17:37 ` [PATCH 16/20] xfs: use bios directly to read and write the log recovery buffers Christoph Hellwig
2019-05-23 17:37 ` [PATCH 17/20] xfs: stop using bp naming for " Christoph Hellwig
2019-05-23 17:37 ` [PATCH 18/20] xfs: remove unused buffer cache APIs Christoph Hellwig
2019-05-23 17:37 ` [PATCH 19/20] xfs: properly type the b_log_item field in struct xfs_buf Christoph Hellwig
2019-05-23 17:37 ` [PATCH 20/20] xfs: remove the b_io_length " Christoph Hellwig
2019-06-03 17:29 use bios directly in the log code v2 Christoph Hellwig
2019-06-03 17:29 ` [PATCH 07/20] xfs: factor out log buffer writing from xlog_sync Christoph Hellwig
2019-06-04 2:20 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524061436.GA2235@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.