From: Stefan Hajnoczi <stefanha@redhat.com>
To: Aarushi Mehta <mehta.aaru20@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
saket.sinha89@gmail.com, Julia Suvorova <jusual@mail.ru>
Subject: Re: [Qemu-devel] [RFC PATCH v2 8/9] block/file-posix: extends to use with io_uring
Date: Fri, 24 May 2019 17:19:16 +0100 [thread overview]
Message-ID: <20190524161916.GH31070@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190524140337.13415-9-mehta.aaru20@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
On Fri, May 24, 2019 at 07:33:36PM +0530, Aarushi Mehta wrote:
> @@ -557,7 +559,9 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
> s->shared_perm = BLK_PERM_ALL;
>
> #ifdef CONFIG_LINUX_AIO
> - /* Currently Linux does AIO only for files opened with O_DIRECT */
> + /*
> + * Currently Linux does AIO only for files opened with O_DIRECT
> + */
> if (s->use_linux_aio) {
The comment's indentation looks off. Is it 4 spaces?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-24 16:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 14:03 [Qemu-devel] [RFC PATCH v2 0/9] Add support for io_uring Aarushi Mehta
2019-05-24 14:03 ` [Qemu-devel] [RFC PATCH v2 1/9] qapi/block-core: add option " Aarushi Mehta
2019-05-24 15:12 ` Stefan Hajnoczi
2019-05-24 16:17 ` Markus Armbruster
2019-05-24 14:03 ` [Qemu-devel] [RFC PATCH v2 2/9] block/block: add BDRV flag " Aarushi Mehta
2019-05-24 15:12 ` Stefan Hajnoczi
2019-05-24 14:03 ` [Qemu-devel] [RFC PATCH v2 3/9] include/block: declare interfaces " Aarushi Mehta
2019-05-24 15:16 ` Stefan Hajnoczi
2019-05-24 14:03 ` [Qemu-devel] [RFC PATCH v2 4/9] stubs: add aio interface stubs " Aarushi Mehta
2019-05-24 15:24 ` Stefan Hajnoczi
2019-05-24 14:03 ` [Qemu-devel] [RFC PATCH v2 5/9] util/async: add aio interfaces " Aarushi Mehta
2019-05-24 15:25 ` Stefan Hajnoczi
2019-05-24 14:03 ` [Qemu-devel] [RFC PATCH v2 6/9] block/io_uring: implements " Aarushi Mehta
2019-05-24 16:17 ` Stefan Hajnoczi
2019-05-24 14:03 ` [Qemu-devel] [RFC PATCH v2 7/9] blockdev: accept io_uring as option Aarushi Mehta
2019-05-24 16:17 ` Stefan Hajnoczi
2019-05-24 14:03 ` [Qemu-devel] [RFC PATCH v2 8/9] block/file-posix: extends to use with io_uring Aarushi Mehta
2019-05-24 16:19 ` Stefan Hajnoczi [this message]
2019-05-24 14:03 ` [Qemu-devel] [RFC PATCH v2 9/9] configure: permit use of io_uring Aarushi Mehta
2019-05-24 16:20 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524161916.GH31070@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=jusual@mail.ru \
--cc=kwolf@redhat.com \
--cc=mehta.aaru20@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=saket.sinha89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.