From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Dave Chinner <david@fromorbit.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH v2 0/5] fstests: copy_file_range() tests
Date: Sun, 26 May 2019 11:45:30 +0300 [thread overview]
Message-ID: <20190526084535.999-1-amir73il@gmail.com> (raw)
Eryu,
This is a re-work of Dave Chinner's copy_file_range() tests which
I used to verify the kernel fixes of the syscall [1].
I split out the single bounds test by Dave to 4 tests.
immutable and swap file copy have specific requiremenet which many
filesystems do not meet (e.g. cifs,nfs,ceph,overlayfs), so those
test cases were split to individual test to allow better bounds test
converage for all filesystems.
The 3 first tests fix bugs in the interface, so they are appropriate
for merge IMO. The last test (cross-device copy) tests a new
functionality, so you may want to wait with merge till after the work
is merged upstream.
NOTE that the bounds check test depend on changes that have been merged
to xfsprogs v4.20. Without those changes the test will hang!
I used an artificial requirement _require_xfs_io_command "chmod" to
skip the test with old xfs_io. I welcome suggestions for better way to
handle this issue.
Thanks,
Amir.
Changes from v1:
- Remove patch to test EINVAL behavior instead of short copy
- Remove 'chmod -r' permission drop test case
- Split out test for swap/immutable file copy
- Split of cross-device copy test
[1] https://lore.kernel.org/linux-fsdevel/20190526061100.21761-1-amir73il@gmail.com/
Amir Goldstein (5):
generic: create copy_range group
generic: copy_file_range immutable file test
generic: copy_file_range swapfile test
generic: copy_file_range bounds test
generic: cross-device copy_file_range test
tests/generic/434 | 2 +
tests/generic/988 | 59 ++++++++++++++++++++
tests/generic/988.out | 5 ++
tests/generic/989 | 56 +++++++++++++++++++
tests/generic/989.out | 4 ++
tests/generic/990 | 123 ++++++++++++++++++++++++++++++++++++++++++
tests/generic/990.out | 37 +++++++++++++
tests/generic/991 | 56 +++++++++++++++++++
tests/generic/991.out | 4 ++
tests/generic/group | 14 +++--
10 files changed, 355 insertions(+), 5 deletions(-)
create mode 100755 tests/generic/988
create mode 100644 tests/generic/988.out
create mode 100755 tests/generic/989
create mode 100644 tests/generic/989.out
create mode 100755 tests/generic/990
create mode 100644 tests/generic/990.out
create mode 100755 tests/generic/991
create mode 100644 tests/generic/991.out
--
2.17.1
next reply other threads:[~2019-05-26 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 8:45 Amir Goldstein [this message]
2019-05-26 8:45 ` [PATCH v2 1/5] generic: create copy_range group Amir Goldstein
2019-05-26 8:45 ` [PATCH v2 2/5] generic: copy_file_range immutable file test Amir Goldstein
2019-05-26 8:45 ` [PATCH v2 3/5] generic: copy_file_range swapfile test Amir Goldstein
2019-05-26 8:45 ` [PATCH v2 4/5] generic: copy_file_range bounds test Amir Goldstein
2019-05-29 2:16 ` Darrick J. Wong
2019-05-29 5:30 ` Amir Goldstein
2019-05-26 8:45 ` [PATCH v2 5/5] generic: cross-device copy_file_range test Amir Goldstein
2019-05-29 3:00 ` [PATCH v2 0/5] fstests: copy_file_range() tests Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190526084535.999-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.