Re: [PATCH] spi: spidev: Fix for reverting spi max speed value only on failure

From: Mark Brown <broonie@kernel.org>
To: Vivek Pernamitta <pervivek@gmail.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: spidev: Fix for reverting spi max speed value only on failure
Date: Mon, 3 Jun 2019 16:57:14 +0100	[thread overview]
Message-ID: <20190603155714.GY2456@sirena.org.uk> (raw)
In-Reply-To: <20190602141959.5616-1-pervivek@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

On Sun, Jun 02, 2019 at 07:49:59PM +0530, Vivek Pernamitta wrote:
> When user space application request for change in spi clock
> using ioctl, current value is taken back-up and new value is
> assigned to spi->max_speed_hz, then spi_setup() function is
> called with new value. If spi_setup() function fails, it needs
> reverting to old spi_max_speed value only in failure condition.

The current behaviour is intentional, we're not modifying max_speed_hz
so we can continue to enforce the kernel limit no matter what userspace
asked for - actually looking at the code we should probably have an
explicit error check in there to reject attempts to raise it here, not
sure why we're not doing that already.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]