From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: Wei Yang <richardw.yang@linux.intel.com>,
dgilbert@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH 0/6] multifd: a new mechanism for send thread sync
Date: Thu, 6 Jun 2019 16:34:55 +0800 [thread overview]
Message-ID: <20190606083501.2087-1-richardw.yang@linux.intel.com> (raw)
Current send thread could work while the sync mechanism has some problem:
* has spuriously wakeup
* number of channels_ready will *overflow* the number of real channels
The reason is:
* if MULTIFD_FLAG_SYNC is set in the middle of send thread running, there
is one more spurious wakeup
* if MULTIFD_FLAG_SYNC is set when send thread is not running, there is one
more channels_ready be triggered
To solve this situation, one new mechanism is introduced to synchronize send
threads. The idea is simple, a new field *sync* is introduced to indicate a
synchronization is required.
Wei Yang (6):
migration/multifd: move MultiFDSendParams handling into
multifd_send_fill_packet()
migration/multifd: notify channels_ready when send thread starts
migration/multifd: use sync field to synchronize send threads
migration/multifd: used must not be 0 for a pending job
migration/multifd: use boolean for pending_job is enough
migration/multifd: there is no spurious wakeup now
migration/ram.c | 62 +++++++++++++++++++++++++++++++------------------
1 file changed, 39 insertions(+), 23 deletions(-)
--
2.19.1
next reply other threads:[~2019-06-06 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 8:34 Wei Yang [this message]
2019-06-06 8:34 ` [Qemu-devel] [PATCH 1/6] migration/multifd: move MultiFDSendParams handling into multifd_send_fill_packet() Wei Yang
2019-06-06 8:34 ` [Qemu-devel] [PATCH 2/6] migration/multifd: notify channels_ready when send thread starts Wei Yang
2019-06-06 8:34 ` [Qemu-devel] [PATCH 3/6] migration/multifd: use sync field to synchronize send threads Wei Yang
2019-06-06 8:34 ` [Qemu-devel] [PATCH 4/6] migration/multifd: used must not be 0 for a pending job Wei Yang
2019-06-06 8:35 ` [Qemu-devel] [PATCH 5/6] migration/multifd: use boolean for pending_job is enough Wei Yang
2019-06-06 8:35 ` [Qemu-devel] [PATCH 6/6] migration/multifd: there is no spurious wakeup now Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606083501.2087-1-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.