From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Cheiny@synaptics.com, aduggan@synaptics.com,
benjamin.tissoires@redhat.com
Subject: Re: [PATCH 2/2] Input: synaptics-rmi4 - export nosleep of f01 via sysfs
Date: Sun, 9 Jun 2019 09:53:19 -0700 [thread overview]
Message-ID: <20190609165319.GA90002@dtor-ws> (raw)
In-Reply-To: <20190220164200.31044-2-aaron.ma@canonical.com>
Hi Aaron,
On Wed, Feb 20, 2019 at 05:42:00PM +0100, Aaron Ma wrote:
> Some of ThinkPad X1C6 touchpads didn't wakeup after resume.
> Forcing enable nosleep make touchpad back.
> Add nosleep via sysfs, so user can control it to workaround issue.
>
> /sys/devices/rmi4-00/nosleep can be written non-zero will enable
> nosleep mode.
I do not think that noseleep attribute is a good solution as users will
have very hard time finding and activating it. If nosleep is absolutely
required, it has to be activated automatically.
However from the discussion on the 1st patch it is my understanding that
this patch was not really required, so I will not be applying it.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-06-09 17:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 16:41 [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs Aaron Ma
2019-02-20 16:42 ` [PATCH 2/2] Input: synaptics-rmi4 - export nosleep of f01 via sysfs Aaron Ma
2019-06-09 16:53 ` Dmitry Torokhov [this message]
2019-03-08 23:13 ` [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs Christopher Heiny
2019-03-09 8:37 ` Aaron Ma
2019-03-28 6:02 ` Aaron Ma
2019-04-02 16:16 ` Christopher Heiny
2019-04-03 13:58 ` Aaron Ma
2019-06-04 2:45 ` Aaron Ma
2019-06-04 5:19 ` Christopher Heiny
2019-06-07 7:48 ` Aaron Ma
2019-06-09 16:55 ` Dmitry Torokhov
2019-06-10 16:55 ` Aaron Ma
2019-06-11 17:35 ` Dmitry Torokhov
2019-06-14 4:26 ` Aaron Ma
2019-11-19 5:34 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609165319.GA90002@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Cheiny@synaptics.com \
--cc=aaron.ma@canonical.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.